Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Modal 컴포넌트 mount시 focus되는 요소 변경 #248

Merged
merged 2 commits into from
May 28, 2023
Merged

Modal 컴포넌트 mount시 focus되는 요소 변경 #248

merged 2 commits into from
May 28, 2023

Conversation

HaJunRyu
Copy link
Member

@HaJunRyu HaJunRyu commented May 27, 2023 •
edited
Loading

변경사항

  • Modal 컴포넌트 mount시 first focusable 요소에 자동으로 focus되던것을 Modal요소 자체에 focus되는것으로 변경합니다.
  • focus되는 Modal 컴포넌트 요소가 focus-visible시에 outline style을 none으로 설정합니다.

작업 유형

  • 리팩토링

체크리스트

  • Merge 할 브랜치가 올바른가?
  • 코딩컨벤션을 준수하였는가?
  • 해당 PR과 관련없는 변경사항이 없는가? (만약 있다면 제목이나 변경사항에 기술하여 주세요.)
  • 실행시 console 창에 에러나 경고가 없는것을 확인하였는가? (개발에 필요하여 고의적으로 남겨둔것 제외)

@HaJunRyu HaJunRyu self-assigned this May 27, 2023
Baek2back
Baek2back approved these changes May 28, 2023
View reviewed changes
Copy link
Member

@Baek2back Baek2back left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

@HaJunRyu HaJunRyu merged commit 24e4059 into develop May 28, 2023
@HaJunRyu HaJunRyu deleted the refactor/home-dialog-focus-style branch May 28, 2023 05:37
@HaJunRyu HaJunRyu mentioned this pull request May 28, 2023
Merged
4 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Baek2back Baek2back Baek2back approved these changes

@sanoopark sanoopark Awaiting requested review from sanoopark sanoopark is a code owner

@kikiyeom kikiyeom Awaiting requested review from kikiyeom kikiyeom is a code owner

Assignees

@HaJunRyu HaJunRyu

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@HaJunRyu @Baek2back