Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

GibbsComputedStructureEntry update to handle float temperature values #4324

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

slee-lab
Copy link

Summary

Issue: when temperature %100==0 but is type float, you get KeyError because G_ELEMS has keys of integer values.

Major changes:

  • feature 1: updated to handle float temperature values
  • fix 1: G_ELEMS[str(self.temp)] is changed to G_ELEMS[str(int(self.temp))]

Checklist

  • Google format doc strings added. Check with ruff.
  • Type annotations included. Check with mypy.
  • Tests added for new features/fixes.
  • If applicable, new classes/functions/modules have duecredit @due.dcite decorators to reference relevant papers by DOI (example)

Tip: Install pre-commit hooks to auto-check types and linting before every commit:

pip install -U pre-commit
pre-commit install

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant