Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update type-hinting for pymatgen.io.qchem.outputs #4330

Merged
merged 2 commits into from
Mar 17, 2025
Merged

Update type-hinting for pymatgen.io.qchem.outputs #4330

merged 2 commits into from
Mar 17, 2025

Conversation

Andrew-S-Rosen
Copy link
Member

Summary

I updated several I/O parsers in pymatgen.io.qchem.outputs such that they are properly type-hinted with str | Path arguments rather than just str.

@DanielYang59
Copy link
Contributor

I guess we have a type alias PathLike which might be preferred to annotate such "pathlike" things:

pymatgen/src/pymatgen/util/typing.py

Line 28 in 168999d

PathLike: TypeAlias = str | OsPathLike 

from pymatgen.util.typing import PathLike

@shyuep shyuep merged commit a13962d into master Mar 17, 2025
44 of 45 checks passed
@shyuep shyuep deleted the Andrew-S-Rosen-patch-1 branch March 17, 2025 13:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@shyuep shyuep Awaiting requested review from shyuep shyuep is a code owner

@mkhorton mkhorton Awaiting requested review from mkhorton mkhorton is a code owner

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@Andrew-S-Rosen @DanielYang59 @shyuep