Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

replace some `|Num.floor _|%N with Num.trunc _ #1432

Merged
merged 1 commit into from
Mar 11, 2025
Merged

Conversation

pi8027
Copy link
Member

@pi8027 pi8027 commented Dec 7, 2024

Motivation for this change

#1244 (comment)

Checklist
  • added corresponding entries in CHANGELOG_UNRELEASED.md
  • added corresponding documentation in the headers

Reference: How to document

Reminder to reviewers

@pi8027 pi8027 changed the title replace some `|Num.floor _| with Num.trunc _ replace some `|Num.floor _|%N with Num.trunc _ Dec 7, 2024
@affeldt-aist affeldt-aist self-requested a review December 9, 2024 04:38
Copy link
Member

@affeldt-aist affeldt-aist left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just add the lemma to the changelog and we are good to go.

@pi8027
Copy link
Member Author

pi8027 commented Dec 9, 2024

Please merge #1415 first.

@pi8027 pi8027 marked this pull request as draft December 9, 2024 09:24
@pi8027 pi8027 force-pushed the norm_floor_trunc branch 3 times, most recently from a1d8a8f to cfcb3eb Compare December 10, 2024 17:01
@proux01
Copy link
Collaborator

proux01 commented Mar 11, 2025

@pi8027 why is this still a draft? Could you please rebase, add the four entries to the changelog and we merge.

@proux01 proux01 added this to the 1.10.0 milestone Mar 11, 2025
@proux01 proux01 marked this pull request as ready for review March 11, 2025 14:55
@proux01
Copy link
Collaborator

proux01 commented Mar 11, 2025

Done, will merge when CI is happy

@pi8027
Copy link
Member Author

pi8027 commented Mar 11, 2025

why is this still a draft?

Because I didn't have time to extensively perform this change and separate orthogonal changes (e.g., divrr -> divff) to another PR (or another commit at least).

@proux01
Copy link
Collaborator

proux01 commented Mar 11, 2025

Ok, the current state of the PR is already an improvement, so let's merge it as it is. Any further change can come in a subsequent PR indeed.

@proux01 proux01 merged commit 99c6924 into master Mar 11, 2025
46 checks passed
@proux01 proux01 deleted the norm_floor_trunc branch March 11, 2025 21:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants