Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix lemma dependency on local hypothesis #1511

Merged

Conversation

affeldt-aist
Copy link
Member

Motivation for this change

This is a bug fix. The lemmas fubini1a and fubini1b (beside being ill-named) depended on a local (strong) hypothesis instead of the intended (weaker) Let as they used to, certainly a consequence of the change of semantics of Let in Coq (I am pretty sure they were right in the first place).

Checklist
  • added corresponding entries in CHANGELOG_UNRELEASED.md

- [ ] added corresponding documentation in the headers

Reference: How to document

Merge policy

As a rule of thumb:

  • PRs with several commits that make sense individually and that
    all compile are preferentially merged into master.
  • PRs with disorganized commits are very likely to be squash-rebased.
Reminder to reviewers

@affeldt-aist affeldt-aist added the "bug" 🐛 This issue (resp. PR) describes (resp. fixes) a "bug" label Mar 7, 2025
@affeldt-aist affeldt-aist added this to the 1.10.0 milestone Mar 7, 2025
@affeldt-aist
Copy link
Member Author

This is uncontroversial so I'll maybe merge if the CI is green.

@affeldt-aist affeldt-aist merged commit 80791d4 into math-comp:master Mar 8, 2025
45 checks passed
@affeldt-aist affeldt-aist deleted the lebesgue_integral_20250307 branch March 8, 2025 02:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
"bug" 🐛 This issue (resp. PR) describes (resp. fixes) a "bug"
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant