Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

preimage_set_system lemmas #1524

Merged
merged 2 commits into from
Mar 13, 2025

Conversation

affeldt-aist
Copy link
Member

Motivation for this change

lemmas used to prove the measurability of behead in the sampling branch

Checklist
  • added corresponding entries in CHANGELOG_UNRELEASED.md

- [ ] added corresponding documentation in the headers

Reference: How to document

Merge policy

As a rule of thumb:

  • PRs with several commits that make sense individually and that
    all compile are preferentially merged into master.
  • PRs with disorganized commits are very likely to be squash-rebased.
Reminder to reviewers

Co-authored-by: Takafumi Saikawa <[email protected]>
@affeldt-aist affeldt-aist added the enhancement ✨ This issue/PR is about adding new features enhancing the library label Mar 12, 2025
@affeldt-aist affeldt-aist added this to the 1.10.0 milestone Mar 12, 2025
@affeldt-aist affeldt-aist requested a review from t6s March 12, 2025 15:23
Copy link
Member

@t6s t6s left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good. We maybe need to add more, but that can be another PR.

@t6s
Copy link
Member

t6s commented Mar 12, 2025

Lemma preimage_set_system_id {aT : Type} {X : set aT} (x : set (set aT)) :
  preimage_set_system X idfun x = (setI X) @` x.
Proof.
rewrite /preimage_set_system; apply/seteqP; split=> u /=.
  by case=> v xv <-; exists v.
by case=> v xv <-; exists v.
Qed.

Can you quickly add this too?

@affeldt-aist
Copy link
Member Author

Can you quickly add this too?

done.

@t6s
Copy link
Member

t6s commented Mar 13, 2025

👍

@affeldt-aist affeldt-aist merged commit 2e6e6bc into math-comp:master Mar 13, 2025
45 checks passed
@affeldt-aist affeldt-aist deleted the measure_20250312 branch March 13, 2025 03:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement ✨ This issue/PR is about adding new features enhancing the library
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants