Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

equivalence between exponential funcitons in stdlib and mca #1525

Merged
merged 4 commits into from
Mar 14, 2025

Conversation

t6s
Copy link
Member

@t6s t6s commented Mar 14, 2025

Motivation for this change

Rtrigo_def.exp in stdlib and expR are equal.

Checklist
  • added corresponding entries in CHANGELOG_UNRELEASED.md
  • added corresponding documentation in the headers

Reference: How to document

Merge policy

As a rule of thumb:

  • PRs with several commits that make sense individually and that
    all compile are preferentially merged into master.
  • PRs with disorganized commits are very likely to be squash-rebased.
Reminder to reviewers

@t6s t6s requested review from affeldt-aist and proux01 March 14, 2025 04:52
Copy link
Member

@affeldt-aist affeldt-aist left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

A definitely needed addition!

@affeldt-aist
Copy link
Member

ah, we might need to adjust dependencies between packages maybe

@t6s
Copy link
Member Author

t6s commented Mar 14, 2025

What a compression rate (in the proof script) 😮 Thanks!

@proux01
Copy link
Collaborator

proux01 commented Mar 14, 2025

ah, we might need to adjust dependencies between packages maybe

If using topology, the result should be in file Rstruct_topology.v and not in Rstruct.v.

@affeldt-aist
Copy link
Member

ah, we might need to adjust dependencies between packages maybe

If using topology, the result should be in file Rstruct_topology.v and not in Rstruct.v.

Indeed!

@affeldt-aist affeldt-aist merged commit 35bcc63 into math-comp:master Mar 14, 2025
45 of 46 checks passed
@t6s t6s deleted the RexpE branch March 14, 2025 15:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants