-
Notifications
You must be signed in to change notification settings - Fork 214
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Pnpm move #1021
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Co-authored-by: Volker Sorge <[email protected]>
pnpm_move update
Made changes as discussed in PR #1023 |
dpvc
approved these changes
Nov 24, 2023
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
One last potential change, but otherwise looks good.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changes build system to
pnpm
. Major changes are:pnpm
does not runpre
andpost
hooks for custom scripts. (They still work for lifecycle scripts).copy
,clean
, etc.:
separation to construct names as meaningful as possible. Exception are some legacy script names - now mainly aliases - likemake-components
.link:full
does not have to execute explicitly anymoreclean
also removesbundle-cjs
pack
now usespnpm
instead ofnpx
. However, the former needs to be executed in the root directory of the repository. So the paths need to be given relative to root and not to the directory of the component that is packed.substr
in the node scripts withsubstring
.