-
Notifications
You must be signed in to change notification settings - Fork 214
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Refactors the Treatment of Namespaces for Methods of TeX Packages #1097
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good. I requested one type of change concerning how methods from previous method objects are included in new ones. Take it or leave it. In any case, I approve.
Done the change as requested. Looks better this way. |
PR removes the old namespacing using a
Record
type and instead uses a single object of type{[key: string]: ParseMethod
that contains all the named methods that we need in theMacroMap
andEnvironmentMap
objects. Layout-wise this has the effect:PackageMethods
object are indented by one extra layer.In addition the PR introduces
enum
types forConfigurationType
andHandlerType
moving away from pure string based naming in configurations.