Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Refactors the Treatment of Namespaces for Methods of TeX Packages #1097

Merged
merged 8 commits into from
Jun 4, 2024

Conversation

zorkow
Copy link
Member

@zorkow zorkow commented May 30, 2024

PR removes the old namespacing using a Record type and instead uses a single object of type {[key: string]: ParseMethod that contains all the named methods that we need in the MacroMap and EnvironmentMap objects. Layout-wise this has the effect:

  1. All methods belonging to the single PackageMethods object are indented by one extra layer.
  2. All auxiliary functions (private to the module or exported) that used to be interspersed are now in the preamble of the module.

In addition the PR introduces enum types for ConfigurationType and HandlerType moving away from pure string based naming in configurations.

@zorkow zorkow changed the title Refactor/namespaces Refactors the Treatment of Namespaces for Methods of TeX Packages May 31, 2024
@zorkow zorkow requested a review from dpvc May 31, 2024 10:52
@zorkow zorkow marked this pull request as ready for review May 31, 2024 10:52
Copy link
Member

@dpvc dpvc left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good. I requested one type of change concerning how methods from previous method objects are included in new ones. Take it or leave it. In any case, I approve.

Base automatically changed from refactor/tests to develop June 4, 2024 10:24
@zorkow
Copy link
Member Author

zorkow commented Jun 4, 2024

Looks good. I requested one type of change concerning how methods from previous method objects are included in new ones. Take it or leave it. In any case, I approve.

Done the change as requested. Looks better this way.

@zorkow zorkow merged commit 4b44784 into develop Jun 4, 2024
@zorkow zorkow deleted the refactor/namespaces branch June 4, 2024 13:01
@dpvc dpvc added this to the v4.0 milestone Jun 5, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants