Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make mspace elements have TEXCLASS.NONE (mathjax/MathJax#2576) #564

Merged
merged 2 commits into from
Feb 9, 2021

Conversation

dpvc
Copy link
Member

@dpvc dpvc commented Dec 3, 2020

Currently, mspace elements have TEXCLASS.ORD, but this causes spacing issues in some instances, for example A=\!=B. This PR sets the texClass to TEXCLASS.NONE and overrides setTeXclass() so that the spacing will be based on the elements surrounding the space, as it is in actual TeX.

Resolves issue mathjax/MathJax#2576.

@dpvc dpvc requested a review from zorkow December 3, 2020 20:16
@dpvc dpvc changed the base branch from master to develop December 3, 2020 20:16
@dpvc dpvc added this to the 3.1.3 milestone Jan 31, 2021
Copy link
Member

@zorkow zorkow left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm.

@dpvc dpvc merged commit 876edcb into develop Feb 9, 2021
@dpvc dpvc deleted the issue2576 branch February 9, 2021 16:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants