Improve spacing between accents and their bases, and handle under- and overlines more like TeX. #619
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…d overlines more like TeX
|
PS, this PR replaces #611. |
That seems odd since underline-overline's PR #611 was closed. |
Oops, read this the wrong way around. Sorry for the noise. |
…oveIc instead and adjust widht after the fact). Also move useIC to common classes since it is inherited, and made the default true (fewer special cases to override).
…CSS size as well)
dpvc
commented
Mar 17, 2021
| // Check if the base is a mi or mo that needs italic correction removed | ||
| // | ||
| if (('noIC' in core) && !(this.constructor as CommonScriptbaseClass).useIC) { | ||
| if (this.baseIsChar && (this.isMathAccent || this.node.isKind('msubsup'))) { |
There was a problem hiding this comment.
Note: This test isn't right, but is fixed in the mathaccent-ic branch.
Fix handling of italic correction for munderover and msubsup combinations.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR changes the character used for
\overlineand\underlineto be U+2015 (HORIZTONAL LINE) and makes them both haveaccent="true"(only\overlinehad that originally) so that the results for both are consistent both in spacing and thickness. It also adds detection of these accents so that the spacing between the line and the base as well as the horizontal placements will match TeX's algorithm, and it adds a bit more space between math accents and the base (since on screen they were getting a bit tight).This resolves issue mathjax/MathJax#2633.