Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add a small separation between base and scripts. (mathjax/MathJax#2406) #636

Merged
merged 2 commits into from
Mar 19, 2021

Conversation

dpvc
Copy link
Member

@dpvc dpvc commented Mar 18, 2021

This PR modifies the super- and subscript positions to leave a small amount of space between the base and the scripts. In TeX, this is handled by italic correction values (that are different for each character), but we don't have that information in the font tables. We may be able to add that during the font update this summer, so this is a bit of a hack to improve the layout until then. It's not perfect, but it helps. See, for example \beta^p before and after:

Before: before

After: after

I also moved the comments that identified what scriptbase functions are for msub and msup, which end up making it look like functions were moved.

Addresses issue mathjax/MathJax#2406.

@dpvc dpvc added this to the 3.1.3 milestone Mar 18, 2021
Copy link
Member

@zorkow zorkow left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm.

Base automatically changed from mathaccent-ic to underline-overline March 19, 2021 18:01
Base automatically changed from underline-overline to develop March 19, 2021 18:12
@dpvc dpvc merged commit 035b1db into develop Mar 19, 2021
@dpvc dpvc deleted the issue2406 branch March 19, 2021 18:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants