Make path resolving more flexible, and don't fail when loading entity files. (mathjax/MathJax#2650) #644
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ilter for entities to load the full entity component when MathML input is used. (mathjax/MathJax#2650)
zorkow
reviewed
Mar 19, 2021
No problem. Thanks for all the reviews. You have done yeoman work today! |
zorkow
approved these changes
Mar 29, 2021
ts/components/loader.ts
Outdated
| }; | ||
| startup?: any; | ||
| } | ||
|
|
||
| /** | ||
| * Functions to used to filter the path to a package |
ts/components/loader.ts
Outdated
| }, | ||
|
|
||
| /** | ||
| * Revursively replace path prefixes (e.g., [mathjax], [tex], etc.) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds a function list to use for resolving the path to a component file (i.e., package), and populates it with several default filters (the ones that were in the original
resolvePath()method). This allows extensions to add or remove the filters as needed, and is used by the MathML input component to handle loading entity files when needed.In the past, the Entities object would try to load entity definitions when an entity wasn't found in its default table. That works for node applications, but for in-browser use, which requires components, not just files, that caused MathJax to fail. (Fortunately, the browser usually handles the entities, but it could cause problems with entities not known in the browser, and in some other edge cases).
This PR resolves that problem by adding a filter to remap attempts to load an entity file to instead load the "all entities" component.
Resolves issue mathjax/MathJax#2650.