Improve heights of successively larger multi-character surds. (mathjax/MathJax#2658) #651
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
zorkow
approved these changes
Mar 29, 2021
| * @param {number} D The requested size of the delimiter | ||
| * @param {DelimiterData} C The data for the delimiter | ||
| * @return {number} The final size of the assembly | ||
| */ |
There was a problem hiding this comment.
This should just be an @override jsdoc.
There was a problem hiding this comment.
I've never fully understood when to use @override. You seem to be saying that if it is described in the interface, then the code that implements that interface should be marked @override. In that case, most of the jsdoc in this class (and in lost of other places) should be turned into @override. Perhaps another cleanup PR is in order?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds the ability to make stretchy multi-character assemblies only use the full size of the extenders. In TeX, this is used by stretchy surds, for example, to make them grow at a standard rate. E.g.,
now produces
with this PR (which is consistent with LaTeX), but used to produce
without it (which is not consistent with LaTeX).
Resolves issue mathjax/MathJax#2658.