Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix issues with placement of menclose notations. (mathjax/MathJax#2571) #660

Merged
merged 2 commits into from
Apr 8, 2021

Conversation

dpvc
Copy link
Member

@dpvc dpvc commented Mar 25, 2021

This PR improves the placement of horizontal and vertical strikes and arrows, and makes sure diagonal arrows fit the actual box used. This addresses the issues in mathjax/MathJax#2571, but we don't fully follow the spec, since we do allow notations to affect each other (e.g., top by itself and top with right will be different width.

The PR also adds a couple of new types for some arrays that are used.

Resolves issue mathjax/MathJax#2571 (for now).

@dpvc dpvc added this to the 3.1.3 milestone Mar 25, 2021
@dpvc dpvc requested a review from zorkow March 25, 2021 23:36
Copy link
Member

@zorkow zorkow left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I've tested the cases I could recall from last week's meeting and they worked.
O/w looks good.

@dpvc dpvc merged commit cd12327 into develop Apr 8, 2021
@dpvc dpvc deleted the issue2571 branch April 8, 2021 16:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants