Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use a colon in link anchor ids so that links work in Safari in SVG output. (mathjax/MathJax#2586) #671

Merged
merged 1 commit into from
Apr 14, 2021

Conversation

dpvc
Copy link
Member

@dpvc dpvc commented Mar 29, 2021

This PR changes the tag id from mjx-eqn-XXX to mjx-eqn:XXX. This is needed in order to get links to work in SVG in Safari. I don't know exactly why that is needed, but it seems to need a character that requires escaping in URLs. Go figure.

Resolves issue mathjax/MathJax#2586.

@dpvc dpvc added this to the 3.1.3 milestone Mar 29, 2021
@dpvc dpvc requested a review from zorkow March 29, 2021 22:27
Copy link
Member

@zorkow zorkow left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good. Again I did not manage to check in Safari.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants