Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add support for all \mathXYZ and \symXYZ macros using multi-letter <mi>. (mathjax/MathJax#2595) #676

Merged
merged 3 commits into from
Apr 20, 2021

Conversation

dpvc
Copy link
Member

@dpvc dpvc commented Mar 31, 2021

This PR adds support for multi-character <mi> elements when they are inside \mathrm, \mathbf, etc., and adds support for all the \mathXYZ and \symXYZ macros, so that all MathML variants can be produced. This has been discussed extensively in mathjax/MathJax#2595, and this is the solution that we agreed on.

This also corrects an error in the variant names in the serialized output, and modifies the autoOP support to only turn normal variants into operators automatically (like <mi>sin</mi>), not the ones created via \mathXYZ{}.

Resolves issue mathjax/MathJax#2595.

…e multi-letter <mi> elements that are not auto-converted to OP elements. (mathjax/MathJax#2595)
@dpvc dpvc added this to the 3.1.3 milestone Mar 31, 2021
@dpvc dpvc requested a review from zorkow March 31, 2021 17:02
Copy link
Member

@zorkow zorkow left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is great! SRE now gets \mathrm{sin} as sine rather than normal s normal i normal n.

@dpvc
Copy link
Member Author

dpvc commented Apr 20, 2021

Yes, that is one of the reasons I worked harder to get the multi-character mi elements, because you said it would help with SRE. Glad that is one of the results!

@dpvc dpvc merged commit 3aeb542 into develop Apr 20, 2021
@dpvc dpvc deleted the issue2595 branch April 20, 2021 20:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants