Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add a11y enable options to menu handler so that they can be configured (mathjax/MathJax#2651) #677

Merged
merged 3 commits into from
Apr 14, 2021

Conversation

dpvc
Copy link
Member

@dpvc dpvc commented Mar 31, 2021

This PR adds the a11y "enable" options to the menu handler so that a page author can include them in the MathJax configuration even if the extensions aren't loaded yet. Without this, having enableExporer, for example, in the configuration would lead to an error about the option not being defined. This defines them when the menu component is loaded, since it may load the a11y extensions later.

Resolves issue mathjax/MathJax#2651.

@dpvc dpvc added this to the 3.1.3 milestone Mar 31, 2021
@dpvc dpvc requested a review from zorkow March 31, 2021 20:58
Copy link
Member

@zorkow zorkow left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just a typo.

@dpvc dpvc merged commit 44e0f70 into develop Apr 14, 2021
@dpvc dpvc deleted the a11y-options branch April 14, 2021 14:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants