Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

\left...\right don't get INNER spacing #2584

Closed
dpvc opened this issue Dec 16, 2020 · 1 comment
Closed

\left...\right don't get INNER spacing #2584

dpvc opened this issue Dec 16, 2020 · 1 comment
Labels
Accepted Issue has been reproduced by MathJax team Fixed Test Needed v3 v3.1
Milestone
3.1.3

Comments

@dpvc
Copy link
Member

dpvc commented Dec 16, 2020

The texClass of INNER is being lost on \left...\right constructs, even though the class is properly displayed in the MathML output. For example, a\left(b\right) does not have the extra space between the a and (.
@dpvc dpvc added the Accepted Issue has been reproduced by MathJax team label Dec 16, 2020
@dpvc
Copy link
Member Author

dpvc commented Dec 16, 2020

This is due to

https://github.com/mathjax/MathJax-src/blob/aa41c0b9362de07c29dcef6de474941385386293/ts/core/MmlTree/MmlNodes/mrow.ts#L157

which incorrectly uses prev to determine if the open is the first element in the list (prev may be the element just before the mrow). This test should either be removed or modified to test for the actual previous element).

dpvc added a commit to mathjax/MathJax-src that referenced this issue Dec 16, 2020
@dpvc
Fix handling of mrows that look like \left...\right to be texClass IN…
3a1abf2 
…NER. (mathjax/MathJax#2584)
@dpvc dpvc mentioned this issue Dec 16, 2020
Merged
@dpvc dpvc added this to the 3.1.3 milestone Jan 31, 2021
dpvc added a commit to mathjax/MathJax-src that referenced this issue Mar 8, 2021
@dpvc
Merge pull request #568 from mathjax/issue2584
684c182 
Fix handling of mrows that look like \left...\right to be texClass INNER.  (mathjax/MathJax#2584)
@dpvc dpvc added Merged Merged into develop branch and removed Ready for Review labels Mar 8, 2021
This was referenced Apr 22, 2021
Merged
Merged
Closed
Closed
Closed
@dependabot dependabot bot mentioned this issue Apr 26, 2021
Closed
@dpvc dpvc added Fixed v3.1 and removed Merged Merged into develop branch labels Apr 27, 2021
@dpvc dpvc closed this as completed Apr 27, 2021
This was referenced May 7, 2021
Merged
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
Accepted Issue has been reproduced by MathJax team Fixed Test Needed v3 v3.1
Projects
None yet
Milestone
3.1.3
Development

No branches or pull requests
1 participant
@dpvc