Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

ERC721 batch withdraw #54

Merged
merged 4 commits into from
Sep 24, 2020
Merged

ERC721 batch withdraw #54

merged 4 commits into from
Sep 24, 2020

Conversation

arthcp
Copy link
Contributor

@arthcp arthcp commented Sep 24, 2020 •
edited
Loading

Burn multiple tokens in one go by calling withdrawBatch function on child token. This emits an event WithdrawnBatch. Predicate checks if event signature is for Transfer or WithdrawnBatch and processes exit based on that.

@arthcp arthcp requested a review from jdkanani September 24, 2020 07:39
@arthcp arthcp merged commit 5036df7 into master Sep 24, 2020
@arthcp arthcp deleted the erc721-batch-withdraw branch September 24, 2020 09:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jdkanani jdkanani jdkanani approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@arthcp @jdkanani