Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Improve signature of MatrixClient::isUsernameAvailable to not rely on throwing #2130

Merged
merged 2 commits into from
Jan 25, 2022
Merged

Improve signature of MatrixClient::isUsernameAvailable to not rely on throwing #2130

merged 2 commits into from
Jan 25, 2022

Conversation

t3chguy
Copy link
Member

@t3chguy t3chguy commented Jan 25, 2022 •
edited by github-actions bot
Loading

This PR currently has no changelog labels, so will not be included in changelogs.

Add one of: T-Deprecation, T-Enhancement, T-Defect, T-Task to indicate what type of change this is plus X-Breaking-Change if it's a breaking change.

@t3chguy t3chguy requested a review from a team as a code owner January 25, 2022 10:06
@t3chguy t3chguy mentioned this pull request Jan 25, 2022
Merged
andybalaam
andybalaam approved these changes Jan 25, 2022
View reviewed changes
Copy link
Member

@andybalaam andybalaam left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good, thanks!

@t3chguy t3chguy merged commit a34426a into develop Jan 25, 2022
@t3chguy t3chguy deleted the t3chguy/fix/20725 branch January 25, 2022 10:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@andybalaam andybalaam andybalaam approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@t3chguy @andybalaam