Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Delete the dehydrated device when resetEncryption is called #4727

Merged
merged 2 commits into from
Feb 21, 2025
Merged

Delete the dehydrated device when resetEncryption is called #4727

merged 2 commits into from
Feb 21, 2025

Conversation

uhoreg
Copy link
Member

@uhoreg uhoreg commented Feb 21, 2025

When we reset encryption (and reset cross-signing keys), delete the dehydrated device since it is (if present) signed with the old cross-signing key.

Fixes element-hq/element-web#29131

Checklist

  • Tests written for new code (and old code if feasible).
  • New or updated public/exported symbols have accurate TSDoc documentation.
  • Linter and other CI checks pass.
  • Sign-off given on the changes (see CONTRIBUTING.md).

@uhoreg uhoreg requested a review from a team as a code owner February 21, 2025 00:43
@uhoreg uhoreg requested a review from richvdh February 21, 2025 00:43
richvdh
richvdh approved these changes Feb 21, 2025
View reviewed changes
Copy link
Member

@richvdh richvdh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Well that was easier than I feared!

Looks like it needs more test coverage.

Also, it would be good to add/update a playwright test to check that this works at the app level.

@uhoreg uhoreg added this pull request to the merge queue Feb 21, 2025
Merged via the queue into matrix-org:develop with commit e49a0a5 Feb 21, 2025
27 checks passed
@uhoreg uhoreg deleted the delete_dehydrated_device_on_reset branch February 21, 2025 21:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@richvdh richvdh richvdh approved these changes

Assignees
No one assigned
Labels
T-Defect
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Device Dehydration: "Reset cryptographic identity" leaves unverified device
2 participants
@uhoreg @richvdh