Skip to content
This repository was archived by the owner on Sep 11, 2024. It is now read-only.

Show buffering while waiting for broadcast chunk #10033

Merged
merged 2 commits into from
Feb 7, 2023

Conversation

weeman1337
Copy link
Contributor

@weeman1337 weeman1337 commented Jan 31, 2023

Show buffering while waiting for the data of a broadcast chunk.

closes element-hq/element-web#24372

PSF-1880

Checklist

  • Tests written for new code (and old code if feasible)
  • Linter and other CI checks pass
  • Sign-off given on the changes (see CONTRIBUTING.md)

This change is marked as an internal change (Task), so will not be included in the changelog.

@weeman1337 weeman1337 added the T-Task Refactoring, enabling or disabling functionality, other engineering tasks label Jan 31, 2023
@weeman1337 weeman1337 force-pushed the weeman1337/broadcast-buffer-chunk branch from c46ebcf to 5f48504 Compare February 1, 2023 14:08
@weeman1337 weeman1337 marked this pull request as ready for review February 1, 2023 15:06
@weeman1337 weeman1337 requested a review from a team as a code owner February 1, 2023 15:06
Copy link
Contributor

@germain-gg germain-gg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Otherwise looks good to me

@weeman1337 weeman1337 added the X-Release-Blocker This affects the current release cycle and must be solved for a release to happen label Feb 6, 2023
@weeman1337 weeman1337 merged commit 4648fa3 into develop Feb 7, 2023
@weeman1337 weeman1337 deleted the weeman1337/broadcast-buffer-chunk branch February 7, 2023 09:14
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
T-Task Refactoring, enabling or disabling functionality, other engineering tasks X-Release-Blocker This affects the current release cycle and must be solved for a release to happen
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Broadcast UI hangs if downloading matrix content takes a while
2 participants