Skip to content
This repository was archived by the owner on Sep 11, 2024. It is now read-only.

Implement updated open dialog method using module API #10536

Closed
wants to merge 1 commit into from

Conversation

maheichyk
Copy link
Contributor

@maheichyk maheichyk commented Apr 6, 2023

Type: Enhancement
Related: matrix-org/matrix-react-sdk-module-api#14

This PR suggests implementation to the updated open dialog method from the module API. It would allow users to control labels for the dialog buttons and enable/disable module submission button.

Checklist

  • Tests written for new code (and old code if feasible)
  • Linter and other CI checks pass
  • Sign-off given on the changes (see CONTRIBUTING.md)

Here's what your changelog entry will look like:

✨ Features

  • Implement updated open dialog method using module API (#10536). Contributed by @maheichyk.

@github-actions github-actions bot added Z-Community-PR Issue is solved by a community member's PR T-Enhancement New features, changes in functionality, performance boosts, user-facing improvements labels Apr 6, 2023
@dhenneke
Copy link
Contributor

Replaced by #11395

@richvdh
Copy link
Member

richvdh commented Aug 10, 2023

Replaced by #11395

can we close it, then?

@maheichyk
Copy link
Contributor Author

Closed in favor of #11395

@maheichyk maheichyk closed this Aug 10, 2023
@Johennes Johennes added A-Timesheet-1 Log any time spent on this into the A-Timesheet-1 project and removed Z-Community-PR Issue is solved by a community member's PR labels Aug 24, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
A-Timesheet-1 Log any time spent on this into the A-Timesheet-1 project T-Enhancement New features, changes in functionality, performance boosts, user-facing improvements
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants