Skip to content
This repository was archived by the owner on Sep 11, 2024. It is now read-only.

Update location.spec.ts - use Cypress Testing Library #10612

Merged
merged 3 commits into from
Apr 17, 2023
Merged

Update location.spec.ts - use Cypress Testing Library #10612

merged 3 commits into from
Apr 17, 2023

Conversation

luixxiul
Copy link
Contributor

@luixxiul luixxiul commented Apr 14, 2023

For element-hq/element-web#25033

type: task

Signed-off-by: Suguru Hirahara [email protected]

Checklist

  • Tests written for new code (and old code if feasible)
  • Linter and other CI checks pass
  • Sign-off given on the changes (see CONTRIBUTING.md)

This change is marked as an internal change (Task), so will not be included in the changelog.

Sorry, something went wrong.

Verified

This commit was signed with the committer’s verified signature.
luixxiul Suguru Hirahara
Signed-off-by: Suguru Hirahara <[email protected]>
…tId()

findByTestId seeks for data-testid, instead of data-test-id.

Signed-off-by: Suguru Hirahara <[email protected]>
@luixxiul luixxiul marked this pull request as ready for review April 15, 2023 05:49
@luixxiul luixxiul requested a review from a team as a code owner April 15, 2023 05:49
@luixxiul luixxiul requested review from richvdh and t3chguy April 15, 2023 05:49
@kerryarchibald kerryarchibald added this pull request to the merge queue Apr 17, 2023
@github-merge-queue github-merge-queue bot removed this pull request from the merge queue due to no response for status checks Apr 17, 2023
@t3chguy t3chguy added this pull request to the merge queue Apr 17, 2023
@github-merge-queue github-merge-queue bot removed this pull request from the merge queue due to a conflict with the base branch Apr 17, 2023
@luixxiul
Copy link
Contributor Author

Fixing the conflict..

@t3chguy t3chguy enabled auto-merge April 17, 2023 08:02
@t3chguy t3chguy added this pull request to the merge queue Apr 17, 2023
Merged via the queue into matrix-org:develop with commit 8125649 Apr 17, 2023
@luixxiul luixxiul deleted the test-location branch April 17, 2023 10:11
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
T-Task Refactoring, enabling or disabling functionality, other engineering tasks Z-Community-PR Issue is solved by a community member's PR
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants