Skip to content
This repository was archived by the owner on Sep 11, 2024. It is now read-only.

Fix warning about being unable to pass ref to function component #10707

Merged
merged 3 commits into from
Apr 27, 2023
Merged

Fix warning about being unable to pass ref to function component #10707

merged 3 commits into from
Apr 27, 2023

Conversation

t3chguy
Copy link
Member

@t3chguy t3chguy commented Apr 25, 2023 •
edited by github-actions bot
Loading

image

This change is marked as an internal change (Task), so will not be included in the changelog.

@t3chguy t3chguy added the T-Task Refactoring, enabling or disabling functionality, other engineering tasks label Apr 25, 2023
@t3chguy t3chguy requested a review from a team as a code owner April 25, 2023 11:59
@t3chguy t3chguy requested review from richvdh and weeman1337 April 25, 2023 11:59
@t3chguy t3chguy self-assigned this Apr 25, 2023
@richvdh
Copy link
Member

richvdh commented Apr 26, 2023

When you say "Fix error" - is this fixing a problem introduced by a previous change? Link it please.

CI seems unhappy.

@t3chguy t3chguy requested a review from a team April 26, 2023 14:22
@richvdh richvdh changed the title Fix error about being unable to pass ref to function component Fix warning about being unable to pass ref to function component Apr 26, 2023
@richvdh
Copy link
Member

richvdh commented Apr 26, 2023

(I'm still waiting for a link to the PR that introduced the problem though?)

58b8df9

So the PR is #10202? Linking to the PR rather than the commit is preferable as it gives a backlink.

@t3chguy
Copy link
Member Author

t3chguy commented Apr 26, 2023

So the PR is #10202? Linking to the PR rather than the commit is preferable as it gives a backlink.

Indeed, though it is quite buried in thatPR

@t3chguy t3chguy added this pull request to the merge queue Apr 27, 2023
@github-merge-queue github-merge-queue bot removed this pull request from the merge queue due to failed status checks Apr 27, 2023
@t3chguy t3chguy added this pull request to the merge queue Apr 27, 2023
Merged via the queue into develop with commit 96bcfc5 Apr 27, 2023
@t3chguy t3chguy deleted the t3chguy/fix-ref-error branch April 27, 2023 10:26
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@richvdh richvdh richvdh approved these changes

@weeman1337 weeman1337 Awaiting requested review from weeman1337 weeman1337 is a code owner automatically assigned from matrix-org/element-web-reviewers

Assignees

@t3chguy t3chguy

Labels
T-Task Refactoring, enabling or disabling functionality, other engineering tasks
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@t3chguy @richvdh