Skip to content
This repository was archived by the owner on Sep 11, 2024. It is now read-only.

Manage style rules of WidgetCard's AppTile on _AppDrawer.pcss #10891

Closed
wants to merge 1 commit into from
Closed

Manage style rules of WidgetCard's AppTile on _AppDrawer.pcss #10891

wants to merge 1 commit into from

Conversation

luixxiul
Copy link
Contributor

@luixxiul luixxiul commented May 13, 2023

For element-hq/element-web#25269

This PR intends to move CSS declarations which style AppTile on BaseCard to _AppDrawer.pcss, in order to concentrate rules related to AppTile in the file.

type: task

Checklist

  • Tests written for new code (and old code if feasible)
  • Linter and other CI checks pass
  • Sign-off given on the changes (see CONTRIBUTING.md)

This change is marked as an internal change (Task), so will not be included in the changelog.

@github-actions github-actions bot added Z-Community-PR Issue is solved by a community member's PR T-Task Refactoring, enabling or disabling functionality, other engineering tasks labels May 13, 2023
@luixxiul luixxiul marked this pull request as ready for review May 13, 2023 16:27
@luixxiul luixxiul requested a review from a team as a code owner May 13, 2023 16:27
Copy link
Contributor

@germain-gg germain-gg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Same review comment as in #10892 (review)

@luixxiul luixxiul closed this Jun 1, 2023
@luixxiul luixxiul deleted the WidgetCard branch June 1, 2023 14:36
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
T-Task Refactoring, enabling or disabling functionality, other engineering tasks Z-Community-PR Issue is solved by a community member's PR
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants