Skip to content
This repository was archived by the owner on Sep 11, 2024. It is now read-only.

Switch from cheerio to DOMParser #10929

Merged
merged 7 commits into from
May 23, 2023
Merged

Switch from cheerio to DOMParser #10929

merged 7 commits into from
May 23, 2023

Conversation

t3chguy
Copy link
Member

@t3chguy t3chguy commented May 17, 2023

For element-hq/element-web#7842


This change is marked as an internal change (Task), so will not be included in the changelog.

@t3chguy t3chguy added the T-Task Refactoring, enabling or disabling functionality, other engineering tasks label May 17, 2023
@t3chguy t3chguy requested review from a team as code owners May 17, 2023 08:33
if (tex) {
phtml(e).html(`<code>${tex}</code>`);
e.innerHTML = `<code>${tex}</code>`;

Check warning

Code scanning / CodeQL

DOM text reinterpreted as HTML

[DOM text](1) is reinterpreted as HTML without escaping meta-characters.
Copy link
Contributor

@germain-gg germain-gg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice! One dependency less, n dependencies to go 🚀

 into t3chguy/cheerio

# Conflicts:
#	test/HtmlUtils-test.tsx
#	test/__snapshots__/HtmlUtils-test.tsx.snap
@t3chguy t3chguy enabled auto-merge May 23, 2023 13:02
@t3chguy t3chguy added this pull request to the merge queue May 23, 2023
Merged via the queue into develop with commit 72d1bd9 May 23, 2023
@t3chguy t3chguy deleted the t3chguy/cheerio branch May 23, 2023 14:02
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
T-Task Refactoring, enabling or disabling functionality, other engineering tasks
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants