Skip to content
This repository was archived by the owner on Sep 11, 2024. It is now read-only.

Switch from cheerio to DOMParser #10929

Merged
merged 7 commits into from
May 23, 2023
Merged

Switch from cheerio to DOMParser #10929

merged 7 commits into from
May 23, 2023

Conversation

t3chguy
Copy link
Member

@t3chguy t3chguy commented May 17, 2023 •
edited by github-actions bot
Loading

For element-hq/element-web#7842

This change is marked as an internal change (Task), so will not be included in the changelog.

@t3chguy t3chguy added the T-Task Refactoring, enabling or disabling functionality, other engineering tasks label May 17, 2023
@t3chguy t3chguy requested review from a team as code owners May 17, 2023 08:33
github-advanced-security[bot]
github-advanced-security bot found potential problems May 17, 2023
View reviewed changes
src/editor/serialize.ts
if (tex) {
phtml(e).html(`<code>${tex}</code>`);
e.innerHTML = `<code>${tex}</code>`;

Check warning

Code scanning / CodeQL

DOM text reinterpreted as HTML

[DOM text](1) is reinterpreted as HTML without escaping meta-characters.
@t3chguy t3chguy self-assigned this May 17, 2023
germain-gg
germain-gg approved these changes May 22, 2023
View reviewed changes
Copy link
Contributor

@germain-gg germain-gg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice! One dependency less, n dependencies to go 🚀

@t3chguy
Merge branch 'develop' of https://github.com/matrix-org/matrix-react-sdk
175ea4a 
 into t3chguy/cheerio

# Conflicts:
#	test/HtmlUtils-test.tsx
#	test/__snapshots__/HtmlUtils-test.tsx.snap
@t3chguy t3chguy enabled auto-merge May 23, 2023 13:02
@t3chguy t3chguy added this pull request to the merge queue May 23, 2023
Merged via the queue into develop with commit 72d1bd9 May 23, 2023
@t3chguy t3chguy deleted the t3chguy/cheerio branch May 23, 2023 14:02
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@germain-gg germain-gg germain-gg approved these changes

@artcodespace artcodespace Awaiting requested review from artcodespace artcodespace is a code owner automatically assigned from matrix-org/element-web-reviewers

Assignees

@t3chguy t3chguy

Labels
T-Task Refactoring, enabling or disabling functionality, other engineering tasks
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@t3chguy @germain-gg