Skip to content
This repository was archived by the owner on Sep 11, 2024. It is now read-only.

Remove url npm dependency and use Web URL constructor #10930

Merged
merged 5 commits into from
May 17, 2023
Merged

Remove url npm dependency and use Web URL constructor #10930

merged 5 commits into from
May 17, 2023

Conversation

t3chguy
Copy link
Member

@t3chguy t3chguy commented May 17, 2023 •
edited by github-actions bot
Loading

Fixes element-hq/element-web#7842

This change is marked as an internal change (Task), so will not be included in the changelog.

@t3chguy t3chguy added the T-Task Refactoring, enabling or disabling functionality, other engineering tasks label May 17, 2023
@t3chguy t3chguy marked this pull request as ready for review May 17, 2023 09:30
@t3chguy t3chguy requested review from a team as code owners May 17, 2023 09:30
andybalaam
andybalaam approved these changes May 17, 2023
View reviewed changes
Copy link
Member

@andybalaam andybalaam left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Brilliant, thanks!

@t3chguy t3chguy merged commit 2da199c into develop May 17, 2023
@t3chguy t3chguy deleted the t3chguy/fix/7842 branch May 17, 2023 11:50
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@andybalaam andybalaam andybalaam approved these changes

@florianduros florianduros Awaiting requested review from florianduros florianduros is a code owner automatically assigned from matrix-org/element-web-reviewers

Assignees
No one assigned
Labels
T-Task Refactoring, enabling or disabling functionality, other engineering tasks
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Replace some dependencies with standard js APIs
2 participants
@t3chguy @andybalaam