Skip to content
This repository was archived by the owner on Sep 11, 2024. It is now read-only.

Revert "Add isLocation to ComposerEvent analytics events" #11190

Merged
merged 1 commit into from
Jul 4, 2023

Conversation

andybalaam
Copy link
Member

@andybalaam andybalaam commented Jul 4, 2023

... because although it fixed CI, it broke local development, and the right fix for CI is to land #11186 and element-hq/element-web#25712

Reverts #11187


This change is marked as an internal change (Task), so will not be included in the changelog.

@andybalaam andybalaam added the T-Task Refactoring, enabling or disabling functionality, other engineering tasks label Jul 4, 2023
@andybalaam andybalaam requested a review from a team as a code owner July 4, 2023 16:15
@andybalaam andybalaam enabled auto-merge July 4, 2023 16:19
@andybalaam andybalaam added this pull request to the merge queue Jul 4, 2023
Merged via the queue into develop with commit 3ad9a8f Jul 4, 2023
@andybalaam andybalaam deleted the andybalaam/remove-islocation branch July 4, 2023 17:03
@richvdh
Copy link
Member

richvdh commented Jul 4, 2023

Which PR is this reverting?

@andybalaam
Copy link
Member Author

Good call Rich, sorry for missing that. It reverts #11187 (now added to description too)

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
T-Task Refactoring, enabling or disabling functionality, other engineering tasks
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants