Skip to content
This repository was archived by the owner on Sep 11, 2024. It is now read-only.

Add face pile to rooms #11356

Merged
merged 18 commits into from
Aug 30, 2023
Merged

Add face pile to rooms #11356

merged 18 commits into from
Aug 30, 2023

Conversation

germain-gg
Copy link
Contributor

@germain-gg germain-gg commented Aug 2, 2023 •
edited by github-actions bot
Loading

For element-hq/element-web#25892

Screen.Recording.2023-08-02.at.16.50.07.mov

Checklist

  • Tests written for new code (and old code if feasible)
  • Linter and other CI checks pass
  • Sign-off given on the changes (see CONTRIBUTING.md)

This change is marked as an internal change (Task), so will not be included in the changelog.

@germain-gg germain-gg added the T-Task Refactoring, enabling or disabling functionality, other engineering tasks label Aug 2, 2023
@germain-gg germain-gg requested review from a team as code owners August 2, 2023 15:59
t3chguy
t3chguy reviewed Aug 2, 2023
View reviewed changes
robintown
robintown reviewed Aug 2, 2023
View reviewed changes
Copy link
Member

@robintown robintown left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Clearing review until the switch to FacePile is done

@robintown robintown removed the request for review from andybalaam August 2, 2023 20:42
@germain-gg germain-gg marked this pull request as draft August 24, 2023 07:55
@germain-gg germain-gg mentioned this pull request Aug 30, 2023
Closed
3 tasks
@germain-gg germain-gg requested a review from robintown August 30, 2023 08:35
@germain-gg germain-gg requested a review from t3chguy August 30, 2023 10:00
@germain-gg germain-gg marked this pull request as ready for review August 30, 2023 10:00
robintown
robintown approved these changes Aug 30, 2023
View reviewed changes
Copy link
Member

@robintown robintown left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Cool, just one thing!

@germain-gg germain-gg enabled auto-merge August 30, 2023 17:00
@robintown robintown removed the request for review from t3chguy August 30, 2023 17:11
@germain-gg germain-gg added this pull request to the merge queue Aug 30, 2023
Merged via the queue into develop with commit dc70ea5 Aug 30, 2023
@germain-gg germain-gg deleted the germain-gg/facepile-roomheader branch August 30, 2023 18:32
@t3chguy t3chguy mentioned this pull request Sep 4, 2023
Closed
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@t3chguy t3chguy t3chguy left review comments

@robintown robintown robintown approved these changes

Assignees
No one assigned
Labels
T-Task Refactoring, enabling or disabling functionality, other engineering tasks
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@germain-gg @t3chguy @robintown