-
-
Notifications
You must be signed in to change notification settings - Fork 827
Add status and management UI for the event indexer #3672
Conversation
From a high level functionality perspective this looks great. I think we can afford to expose a little more information to the user to give them more visibility and a sense of control though (at least until we are confident this works seamlessly).
In terms of where it should sit in the UI - I'd have expected it to be in Security & Privacy alongside the rest of the E2E settings. @nadonomy: can you provide a design for this please? |
@poljar for when you're back after Christmas/New Years I've added a design proposal for the seshat UI here: https://www.figma.com/file/wwqBo5oAFfk8XKmtd2YaIs/Cross-signing?node-id=2011%3A497 Let me know when you're back online on Matrix and we can iterate on some of the details. From the requirements I could gather from this issue, there's a few things that would be good to discuss:
|
I guess bellow the key backup section seems sensible?
As it is, it would restart the download. Agree a Disable/Enable could be enough.
Agree, a summary should be enough, but some type of marker could be nice for when a user looks at a specific room. Just some visual hint if messages are being downloaded or not.
Eventually, yes. No progress as of yet on that side though. |
d20bcbe
to
8e26268
Compare
This changes the way the event index is initialized, if it's disabled in the settings it will not be initialized at all, before only the crawler loop was not being started.
If we're cancelling the crawler nowadays this means that we're likely deleting the index. Processing these messages is wasted effort in that case so break early.
src/async-components/views/dialogs/eventindex/DisableEventIndexDialog.js
Outdated
Show resolved
Hide resolved
src/async-components/views/dialogs/eventindex/ManageEventIndexDialog.js
Outdated
Show resolved
Hide resolved
src/async-components/views/dialogs/eventindex/DisableEventIndexDialog.js
Outdated
Show resolved
Hide resolved
src/async-components/views/dialogs/eventindex/DisableEventIndexDialog.js
Show resolved
Hide resolved
src/async-components/views/dialogs/eventindex/ManageEventIndex.js
Outdated
Show resolved
Hide resolved
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
We're nearly there, just a few more things to tweak!
Updated now to have a red transparent cancel button on the disable dialog. I left the border around the button since it seemed a bit weird not having it there. The colors aren't the transparent ones like in the figma but I assume we want to switch those around all at once and be consistent for now. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks great overall! Feel free to adjust the links as mentioned and land; no need for another review.
Thanks for working on this! 😁
"with <nativeLink>search components added</nativeLink>.", | ||
{}, | ||
{ | ||
'nativeLink': (sub) => <a href={nativeLink}>{sub}</a>, |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Please add target="_blank" rel="noopener"
to this link and the one below so they open in new tabs.
This PR implements some initial UI for our event indexer.
Things that are configurable/shown:
Some more things we might want:
As for configuring non-encrypted rooms we should consider if we want to allow users to index any type of room or limit it to non-public rooms or DMs only.
Rendered:
The settings have been crammed into the preferences tab of the user settings. This is most likely the completely wrong place to put them since we already have quite a large number of settings there.
A new tab for the settings was also considered but we may have enough tabs as well.
Please note that this PR depends on changes in Riot-web as well (element-hq/element-web#11529)
Fixes element-hq/element-web#11984