This repository was archived by the owner on Sep 11, 2024. It is now read-only.
Defer encryption setup until first E2EE room #5219
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
With this change, Element now creates cross-signing keys during auth flows for password login. For other auth flows like token / SSO, it will not happen until a cross-signing / secret storage dialog flow as before.
This ensures we are alerted when you first interact with an encrypted room. Part of element-hq/element-web#13895
The Secure Backup toast replaces this with better UX. Part of element-hq/element-web#13895
This adjusts the main toast to focus on Secure Backup as suggested in designs. Part of element-hq/element-web#13895
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This work simplifies registration and login by removing the passphrase setup step. We now wait until the user interacts with their first encrypted room, and only then start displaying toasts to setup Secure Backup and security related features.
Cross-signing keys are created as early as possible (during auth for password users, delayed to Secure Backup setup for SSO users).
Reviewer: It's likely best to go commit by commit, as there are several commits which reorganise files.
Fixes element-hq/element-web#13895