Skip to content
This repository was archived by the owner on Sep 11, 2024. It is now read-only.

Disable e2e config #5652

Closed

Conversation

djschilling
Copy link
Contributor

@djschilling djschilling commented Feb 16, 2021

This pr adds a new config option disableEncryption .

It disables the creation of the crypto store, which leads to element not showing e2e encryption options.
Mainly it disables all encryption screens when logging into element web.

Fixes element-hq/element-meta#292


Here's what your changelog entry will look like:

✨ Features

@SimonBrandner
Copy link
Contributor

@djschilling, please include a sign-off as described here

@djschilling
Copy link
Contributor Author

@SimonBrandner done

@jryans jryans requested review from a team and removed request for a team February 22, 2021 10:19
@jryans
Copy link
Collaborator

jryans commented Feb 22, 2021

I suspect we'll need some form of Product review here, but for now at least adding to the code review queue.

@djschilling
Copy link
Contributor Author

I just added one commit.
When creating a new room, the check if e2e-encryption is available, was missing there.

@jryans
Copy link
Collaborator

jryans commented Feb 22, 2021

@djschilling I am afraid I don't agree that this matches this issues you linked... The first issue is about disabling encryption in the homeserver config file, and the second is a (fixed) issue about well-known that can tell Element to disable encryption for a server.

Could you first open an issue to describe your use case? It's not obvious why you want this solution at the moment.

@jryans jryans removed the request for review from a team February 22, 2021 17:40
@djschilling
Copy link
Contributor Author

@jryans thanks for the reply.

I opened an issue with more explanation: element-hq/element-meta#292

@djschilling djschilling force-pushed the disable-e2e-config branch from 33b98f5 to 5cdbecd Compare May 25, 2021 09:48
@DoM1niC
Copy link

DoM1niC commented Jul 13, 2021

This pr adds a new config option disableEncryption .

It disables the creation of the crypto store, which leads to element not showing e2e encryption options.
Mainly it disables all encryption screens when logging into element web.

Fixes vector-im/element-meta#292

I wanne use your PR could you solve the conflicts for me ?

@djschilling
Copy link
Contributor Author

@DoM1niC i am happy to resolve the conflicts if there is a chance that this gets merged.

@DoM1niC
Copy link

DoM1niC commented Jul 13, 2021

@DoM1niC i am happy to resolve the conflicts if there is a chance that this gets merged.

I merged your PR from ChurchTools but my e2e still active how I set the flag to disableEncyption Stuff?

@djschilling
Copy link
Contributor Author

@DoM1niC you have to set the config flag disableEncryption

@daniellekirkwood daniellekirkwood self-requested a review May 19, 2022 14:05
@MadLittleMods MadLittleMods added Z-Community-PR Issue is solved by a community member's PR T-Enhancement New features, changes in functionality, performance boosts, user-facing improvements labels Jun 2, 2022
@daniellekirkwood
Copy link

Thank you for your contribution. We appreciate the time and effort you've taken to improve our platform however this feature is not something that we'd like to support right now. Encryption is one of our core features therefore, we will decline and close this PR. Please let me know if you have any questions.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
T-Enhancement New features, changes in functionality, performance boosts, user-facing improvements Z-Community-PR Issue is solved by a community member's PR
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Option to disable e2e-encryption
6 participants