-
-
Notifications
You must be signed in to change notification settings - Fork 827
Conversation
263ec66
to
8c91093
Compare
@djschilling, please include a sign-off as described here |
8c91093
to
94473f0
Compare
@SimonBrandner done |
I suspect we'll need some form of Product review here, but for now at least adding to the code review queue. |
I just added one commit. |
bcf3559
to
bdc4acc
Compare
@djschilling I am afraid I don't agree that this matches this issues you linked... The first issue is about disabling encryption in the homeserver config file, and the second is a (fixed) issue about well-known that can tell Element to disable encryption for a server. Could you first open an issue to describe your use case? It's not obvious why you want this solution at the moment. |
bdc4acc
to
dbdcd4b
Compare
@jryans thanks for the reply. I opened an issue with more explanation: element-hq/element-meta#292 |
704c08e
to
93ff164
Compare
1656f65
to
33b98f5
Compare
Signed-off-by: David Schilling <[email protected]>
…ailable Signed-off-by: David Schilling <[email protected]>
Signed-off-by: David Schilling <[email protected]>
33b98f5
to
5cdbecd
Compare
I wanne use your PR could you solve the conflicts for me ? |
@DoM1niC i am happy to resolve the conflicts if there is a chance that this gets merged. |
I merged your PR from ChurchTools but my e2e still active how I set the flag to disableEncyption Stuff? |
@DoM1niC you have to set the config flag |
Thank you for your contribution. We appreciate the time and effort you've taken to improve our platform however this feature is not something that we'd like to support right now. Encryption is one of our core features therefore, we will decline and close this PR. Please let me know if you have any questions. |
This pr adds a new config option
disableEncryption
.It disables the creation of the crypto store, which leads to element not showing e2e encryption options.
Mainly it disables all encryption screens when logging into element web.
Fixes element-hq/element-meta#292
Here's what your changelog entry will look like:
✨ Features