Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Message ID support: The sending side #1946

Merged
merged 3 commits into from
May 24, 2023
Merged

Message ID support: The sending side #1946

merged 3 commits into from
May 24, 2023

Conversation

poljar
Copy link
Contributor

@poljar poljar commented May 19, 2023

This closes: #1266

The first patch cleans some logs up, secondly we add optional support to send
message IDs for our m.room.encrypted to-device events, and finally we log the
message ID when we encrypt room keys.

  • Public API changes documented in changelogs (optional)

@poljar poljar requested a review from a team as a code owner May 19, 2023 12:18
@poljar poljar requested review from bnjbvr and removed request for a team May 19, 2023 12:18
@codecov
Copy link

codecov bot commented May 19, 2023

Codecov Report

Patch coverage: 84.09% and project coverage change: +0.08 🎉

Comparison is base (c042e1e) 75.72% compared to head (b6bb0f3) 75.81%.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #1946      +/-   ##
==========================================
+ Coverage   75.72%   75.81%   +0.08%     
==========================================
  Files         142      142              
  Lines       16271    16276       +5     
==========================================
+ Hits        12321    12339      +18     
+ Misses       3950     3937      -13     
Impacted Files Coverage Δ
crates/matrix-sdk-crypto/src/gossiping/machine.rs 63.39% <50.00%> (+2.53%) ⬆️
...x-sdk-crypto/src/session_manager/group_sessions.rs 86.29% <79.16%> (-0.02%) ⬇️
crates/matrix-sdk-crypto/src/identities/device.rs 74.80% <100.00%> (+0.50%) ⬆️
crates/matrix-sdk-crypto/src/olm/account.rs 82.93% <100.00%> (+0.04%) ⬆️
crates/matrix-sdk-crypto/src/olm/session.rs 98.18% <100.00%> (+0.03%) ⬆️
...trix-sdk-crypto/src/types/events/room/encrypted.rs 83.05% <100.00%> (+1.56%) ⬆️

☔ View full report in Codecov by Sentry.
📢 Do you have feedback about the report comment? Let us know in this issue.

@poljar
Copy link
Contributor Author

poljar commented May 19, 2023

And ulid doesn't work on WASM 🥲.

@bnjbvr
Copy link
Member

bnjbvr commented May 19, 2023

Ah, makes sense; it probably requires a source of randomness or time for the wasm side that it doesn't have otherwise; it could be done via a custom import, or... compiling to the WASI target and include a WASI polyfill in the browser.

@poljar poljar force-pushed the poljar/message-id-support branch from 523bf39 to b7ce432 Compare May 24, 2023 09:24
@poljar poljar force-pushed the poljar/message-id-support branch from b7ce432 to b6bb0f3 Compare May 24, 2023 09:57
@poljar poljar enabled auto-merge (rebase) May 24, 2023 10:01
@poljar poljar merged commit 5e3a114 into main May 24, 2023
@poljar poljar deleted the poljar/message-id-support branch May 24, 2023 10:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add a message ID to most of the to-device contents
2 participants