crypto: Add a standalone integration test for the NSE race #3343
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
andybalaam
requested review from
Hywan
and removed request for
a team and
Hywan
|
Undrafted to get integration test |
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #3343 +/- ##
==========================================
- Coverage 83.18% 83.08% -0.10%
==========================================
Files 243 243
Lines 25211 24985 -226
==========================================
- Hits 20971 20759 -212
+ Misses 4240 4226 -14 ☔ View full report in Codecov by Sentry. |
andybalaam
force-pushed
the
andybalaam/test-store-cache-drop
branch
5 times, most recently
from
1c9be17 to
5042f75
Compare
bnjbvr
changed the title
andybalaam
force-pushed
the
andybalaam/test-store-cache-drop
branch
8 times, most recently
from
efc18f6 to
38225a8
Compare
|
Do you need help? |
Thank you, no I think I'm nearly there - Rich and I made a breakthough yesterday. |
andybalaam
force-pushed
the
andybalaam/test-store-cache-drop
branch
5 times, most recently
from
492bf2b to
d32be87
Compare
andybalaam
force-pushed
the
andybalaam/test-store-cache-drop
branch
from
d32be87 to
6d78f83
Compare
andybalaam
force-pushed
the
andybalaam/test-store-cache-drop
branch
6 times, most recently
from
60d10d6 to
c68fa01
Compare
bnjbvr
changed the title
andybalaam
force-pushed
the
andybalaam/test-store-cache-drop
branch
from
c68fa01 to
b355470
Compare
andybalaam
changed the title
andybalaam
force-pushed
the
andybalaam/test-store-cache-drop
branch
from
b355470 to
af35ac0
Compare
andybalaam
force-pushed
the
andybalaam/test-store-cache-drop
branch
from
af35ac0 to
a78d788
Compare
andybalaam
changed the title
|
Requesting review from @Hywan since he was initially chosen. This is (finally) ready for a first look from you, thanks! |
|
@andybalaam the integration test doesn't compile on CI, can you take a look please? thanks! |
Hywan
approved these changes
May 13, 2024
andybalaam
force-pushed
the
andybalaam/test-store-cache-drop
branch
from
a78d788 to
6c6a33c
Compare
Adds a test for #3110 that fails before the fix and passes afterwards.
andybalaam
force-pushed
the
andybalaam/test-store-cache-drop
branch
from
6c6a33c to
06825c6
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adds a test that fails before #3338 and passes afterwards.
Tests the fix for #3110
The test sets up a cross-process lock and 2 clients using it, then makes sure they both have Olm sessions with a 3rd client, before sending from one of them and checking that the other can still receive. This validates that it flushed and replaced its Olm session with the 3rd client.