Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

MSC3069: Allow guests to use /account/whoami #3069

Merged
merged 2 commits into from
Oct 24, 2021

Conversation

turt2live
Copy link
Member

@turt2live turt2live commented Mar 19, 2021

Rendered

Server implementation: matrix-org/synapse#9655
"Client" implementation: t2bot/matrix-media-repo@b518118

@turt2live turt2live changed the title Allow guests to use /account/whoami MSC3069: Allow guests to use /account/whoami Mar 19, 2021
@turt2live turt2live added kind:maintenance MSC which clarifies/updates existing spec proposal A matrix spec change proposal proposal-in-review labels Mar 19, 2021
@turt2live
Copy link
Member Author

Synapse implementation has finally merged - I think this is ready for FCP.

Copy link
Member

@uhoreg uhoreg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

seems sensible

@turt2live
Copy link
Member Author

I'm assuming that approval also means ready for FCP:

@mscbot fcp merge

@mscbot
Copy link
Collaborator

mscbot commented Oct 4, 2021

Team member @turt2live has proposed to merge this. The next step is review by the rest of the tagged people:

Once at least 75% of reviewers approve (and there are no outstanding concerns), this will enter its final comment period. If you spot a major issue that hasn't been raised at any point in this process, please speak up!

See this document for information about what commands tagged team members can give me.

@mscbot mscbot added disposition-merge proposed-final-comment-period Currently awaiting signoff of a majority of team members in order to enter the final comment period. and removed proposal-in-review labels Oct 4, 2021
@mscbot
Copy link
Collaborator

mscbot commented Oct 19, 2021

🔔 This is now entering its final comment period, as per the review above. 🔔

@mscbot mscbot added final-comment-period This MSC has entered a final comment period in interest to approval, postpone, or delete in 5 days. and removed proposed-final-comment-period Currently awaiting signoff of a majority of team members in order to enter the final comment period. labels Oct 19, 2021
@mscbot
Copy link
Collaborator

mscbot commented Oct 24, 2021

The final comment period, with a disposition to merge, as per the review above, is now complete.

@mscbot mscbot added finished-final-comment-period and removed disposition-merge final-comment-period This MSC has entered a final comment period in interest to approval, postpone, or delete in 5 days. labels Oct 24, 2021
@turt2live turt2live merged commit 7885c6a into old_master Oct 24, 2021
@turt2live turt2live deleted the travis/msc/whoami-guests branch October 24, 2021 19:17
@turt2live turt2live added the spec-pr-missing Proposal has been implemented and is being used in the wild but hasn't yet been added to the spec label Oct 24, 2021
@turt2live turt2live self-assigned this Dec 29, 2021
@turt2live turt2live added spec-pr-in-review A proposal which has been PR'd against the spec and is in review and removed spec-pr-missing Proposal has been implemented and is being used in the wild but hasn't yet been added to the spec labels Dec 29, 2021
@turt2live
Copy link
Member Author

Spec PR: #3605

@turt2live
Copy link
Member Author

Merged 🎉

@turt2live turt2live added merged A proposal whose PR has merged into the spec! and removed spec-pr-in-review A proposal which has been PR'd against the spec and is in review labels Jan 5, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
kind:maintenance MSC which clarifies/updates existing spec merged A proposal whose PR has merged into the spec! proposal A matrix spec change proposal
Projects
Archived in project
Development

Successfully merging this pull request may close these issues.

5 participants