-
Notifications
You must be signed in to change notification settings - Fork 392
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
MSC4101: Hashes for unencrypted media #4101
base: main
Are you sure you want to change the base?
Conversation
to clients. Clients will believe these changes in most cases because they do not have the capability | ||
to validate the DAG itself. | ||
|
||
This proposal does *not* attempt to fix either tampering issue for unencrypted media. Encrypting events |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I'm surprised we're not mentioning MSC #2757 (https://github.com/Sorunome/matrix-doc/blob/soru/sign-events/proposals/2757-sign-events.md ) here, which /does/ try to fix the tampering issue for unencrypted media (and is kinda the sister-proposal to this, but for events rather than media)
|
||
## Alternatives | ||
|
||
No alternatives identified. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Can't the hash just go into the MXC URI e.g "thumbnail_url": "mxc://example.org/$hash"
?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
If we have an MSC3911 world, no. The media ID would need to be unique.
We'd also find it harder to update or change the algorithm in future, but not impossible.
Rendered
In line with matrix-org/matrix-spec#1700, the following disclosure applies:
I am Director of Standards Development at The Matrix.org Foundation C.I.C., Matrix Spec Core Team (SCT) member, employed by Element, and operate the t2bot.io service. This proposal is written and published as a member of the SCT working in the area of media authentication and linking.
Implementation requirements: