Make disclosure of conflicts of interest mandatory for spec change proposals #2079
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Fixes: matrix-org#1700 Signed-off-by: Johannes Marbach <[email protected]>
Johennes
changed the title
Johennes
commented
Feb 21, 2025
| @@ -193,7 +206,8 @@ is as follows: | |||
| filename that follows the format `1234-my-new-proposal.md` where | |||
| `1234` is the MSC ID. | |||
| - Your PR description must include a link to the rendered Markdown | |||
| document and a summary of the proposal. | |||
| document and a disclosure of potential conflicts of interest where | |||
| they might reasonably apply. | |||
There was a problem hiding this comment.
Empirically, proposal summaries in the PR description don't appear to happen at all in practice. Therefore, I've dropped this part when adding the CoI clause.
Johennes
commented
Feb 21, 2025
| For the purposes of transparency and to underpin the "greater benefit" | ||
| principle, proposals MUST disclose possible conflicts of interest where | ||
| they might reasonably exist. Authors MAY do this by filling out the | ||
| following checklist and publishing it together with their proposal. |
There was a problem hiding this comment.
It is debatable whether RFC2119 language makes sense here. I found it helpful for differentiating between hard and optional requirements. I might be partial to this language by having worked with it in the spec for too long, however.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes: #1700
Pull Request Checklist
Preview: https://pr2079--matrix-spec-previews.netlify.app