Skip to content
This repository was archived by the owner on Apr 26, 2024. It is now read-only.

Add avatar and topic settings for server notice room #16679

Merged
merged 12 commits into from
Dec 12, 2023
Merged

Add avatar and topic settings for server notice room #16679

merged 12 commits into from
Dec 12, 2023
+235 −14

Conversation

MatMaul
Copy link
Contributor

@MatMaul MatMaul commented Nov 23, 2023 •
edited
Loading

Signed-off-by: Mathieu Velten [email protected]

Pull Request Checklist

@github-actions github-actions bot deployed to PR Documentation Preview November 23, 2023 13:54 Active
@github-actions github-actions bot deployed to PR Documentation Preview November 23, 2023 13:55 Active
@github-actions github-actions bot deployed to PR Documentation Preview November 23, 2023 15:35 Active
@github-actions github-actions bot deployed to PR Documentation Preview November 23, 2023 15:58 Active
@github-actions github-actions bot deployed to PR Documentation Preview November 23, 2023 17:00 Active
@github-actions github-actions bot deployed to PR Documentation Preview November 23, 2023 18:31 Active
@MatMaul MatMaul marked this pull request as ready for review November 28, 2023 15:08
@MatMaul MatMaul requested a review from a team as a code owner November 28, 2023 15:08
@MatMaul MatMaul requested a review from clokep November 30, 2023 16:17
@clokep clokep requested review from a team and removed request for clokep November 30, 2023 16:46
@DMRobertson
Copy link
Contributor

I left some thoughts, but had to stop before I got to _update_room_info.

@DMRobertson DMRobertson requested a review from a team December 6, 2023 15:38
@MatMaul MatMaul requested a review from DMRobertson December 7, 2023 09:29
erikjohnston
erikjohnston reviewed Dec 12, 2023
View reviewed changes
Copy link
Member

@erikjohnston erikjohnston left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just some minor nits

@MatMaul MatMaul requested a review from erikjohnston December 12, 2023 14:11
@erikjohnston erikjohnston merged commit e108c31 into matrix-org:develop Dec 12, 2023
@erikjohnston
Copy link
Member

Thanks ❤️

@odelcroi odelcroi mentioned this pull request Apr 2, 2024
Closed
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@clokep clokep clokep left review comments

@DMRobertson DMRobertson Awaiting requested review from DMRobertson

@erikjohnston erikjohnston Awaiting requested review from erikjohnston

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@MatMaul @DMRobertson @erikjohnston @clokep