Skip to content
This repository was archived by the owner on Apr 26, 2024. It is now read-only.

Call set_avatar_url with target_user, not user_id #8872

Merged
merged 5 commits into from
Dec 7, 2020
Merged

Call set_avatar_url with target_user, not user_id #8872

Show file tree
Hide file tree
Changes from 2 commits
Commits
Show all changes
5 commits
Select commit Hold shift + click to select a range
c2b67ab
Call set_avatar_url with target_user, not user_id
Half-Shot Dec 3, 2020
ad0975d
Create 8872.bugfix
Half-Shot Dec 3, 2020
af7fcdb
Update synapse/rest/admin/users.py
Half-Shot Dec 3, 2020
c174322
Testing
Half-Shot Dec 7, 2020
5b1052d
Update changelog.d/8872.bugfix
Half-Shot Dec 7, 2020
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions changelog.d/8872.bugfix
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1 @@
Fix `PUT /_synapse/admin/v2/users/<user_id>` failing to create a new user when `avatar_url` is specified.
2 changes: 1 addition & 1 deletion synapse/rest/admin/users.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -322,7 +322,7 @@ async def on_PUT(self, request, user_id):

if "avatar_url" in body and type(body["avatar_url"]) == str:
await self.profile_handler.set_avatar_url(
user_id, requester, body["avatar_url"], True
target_user, requester, body["avatar_url"], True
)

ret = await self.admin_handler.get_user(target_user)
Expand Down