-
Notifications
You must be signed in to change notification settings - Fork 71
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Does not return timezone for this lat long: tzwhere.tzNameAt(40.573238372802734, -73.99983978271484) #8
Comments
Interesting. Is there a newer/more correct set of source data available anywhere? |
I found this problem while using the Python port pytzwhere. @mattbornski, it also happens at Spain' southern coast. |
Interesting to note that the Earth's land surface is of course always changing, whereas these polygons were generated by some person at one point in time and are not changing at the same rate. It seems natural to me that if I am off the coast of a landmass, I would treat myself as being in the timezone of that landmass. Is there any convention on that? If (hypothetically) there was some nautical convention that specified that ships at sea are not in any timezone, then what if we added a config flag for the sanity of anybody who is not oceangoing and fudged points outside of all polygons into the nearest polygon? |
When I discovered the issue I shot Eric Muller (the author of the data) an email asking if I was doing something wrong, and he explained:
Incidentally here's Paris (these were rendered by downloading Eric's tz_world.zip, running |
I am not sure how relevant this is for this package, but I implemented a workaround in the python port of this package. See also this discussion. |
The json data seems corrupt. This fixes [mattbornski#8](mattbornski#18)
tzwhere.tzNameAt(40.573238372802734, -73.99983978271484) => Null
Returns a null, but should be this: http://www.darrinward.com/lat-long/?id=92197
The text was updated successfully, but these errors were encountered: