Make vendored logrus library reflect vendor.json #69
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mattbostock
force-pushed
the
check_vendor
branch
from
1a68582 to
9e70f72
Compare
I ran `govendor status` to check the integrity of vendored packages and
found that the vendored copy of the logrus library did not match the
version pinned in `vendor.json`.
govendor gave the following error:
$ govendor status
The following packages are missing or modified locally:
github.com/Sirupsen/logrus
Error: status failed for 1 package(s)
Additionally, remove the unused lowercase variant of logrus from
`vendor.json`. The URL for this library changed upstream to use
lowercase `sirupsen` instead of `Sirupsen`. The best way forward for now
is to continue to use the uppercase version as that's what's used by the
Prometheus libraries; mixed-case imports result in an import collision:
can't load package: package github.com/sirupsen/logrus: case-insensitive import collision: "github.com/Sirupsen/logrus" and "github.com/sirupsen/logrus"
See this comment for more details:
sirupsen/logrus#570 (comment)
mattbostock
force-pushed
the
check_vendor
branch
from
9e70f72 to
2be5b22
Compare
This way is more readable.
Fail tests if libraries are missing from the vendor folder, if the libraries in the vendor folder do not match the version in `vendor.json` or if libraries are vendored but not actually used in the project. Test for broken dependencies first in Travis so that tests will fail fast as the `testdeps` target should return faster than `test` will.
mattbostock
force-pushed
the
check_vendor
branch
from
2be5b22 to
41e8605
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I ran
govendor statusto check the integrity of vendored packages andfound that the vendored copy of the logrus library did not match the
version pinned in
vendor.json.govendor gave the following error:
Additionally, remove the unused lowercase variant of logrus from
vendor.json. The URL for this library changed upstream to uselowercase
sirupseninstead ofSirupsen. The best way forward for nowis to continue to use the uppercase version as that's what's used by the
Prometheus libraries; mixed-case imports result in an import collision:
See this comment for more details:
sirupsen/logrus#570 (comment)
Also, fail CI tests if inconsistencies are found in vendored packages or if unused packages are found in the
vendor/directory.