[DO NOT MERGE] ci: optimize and unify scripts and build process #550

antonbaliasnikov · 2024-05-20T10:11:45Z

What ❔

Unify and update CI scripts: introduce matrix jobs, use common integration tests and benchmarks (remove necessity to create special configs)
Rename ZKEVM to ZKsync everywhere
Fix versioning - use only the second part of the tag as the ZKsync version
Make the ZKsync part of the changelog more unified

Why ❔

Fixes CPR-1689

Checklist

PR title corresponds to the body of PR (we generate changelog entries from PRs).
Tests for the changes have been added / updated.
Documentation comments have been added / updated.

github-actions · 2024-05-21T13:01:53Z

Benchmark results:

╔═╡ Size (-%) ╞════════════════╡ All M3B3 ╞═╗
║ Mean                                0.000 ║
║ Best                                0.000 ║
║ Worst                               0.000 ║
║ Total                               0.000 ║
╠═╡ Cycles (-%) ╞══════════════╡ All M3B3 ╞═╣
║ Mean                                0.000 ║
║ Best                                0.000 ║
║ Worst                               0.000 ║
║ Total                               0.000 ║
╠═╡ Ergs (-%) ╞════════════════╡ All M3B3 ╞═╣
║ Mean                                0.000 ║
║ Best                                0.000 ║
║ Worst                               0.000 ║
║ Total                               0.000 ║
╚═══════════════════════════════════════════╝

╔═╡ Size (-%) ╞════════════════╡ All MzB3 ╞═╗
║ Mean                                0.000 ║
║ Best                                0.000 ║
║ Worst                               0.000 ║
║ Total                               0.000 ║
╠═╡ Cycles (-%) ╞══════════════╡ All MzB3 ╞═╣
║ Mean                                0.000 ║
║ Best                                0.000 ║
║ Worst                               0.000 ║
║ Total                               0.000 ║
╠═╡ Ergs (-%) ╞════════════════╡ All MzB3 ╞═╣
║ Mean                                0.000 ║
║ Best                                0.000 ║
║ Worst                               0.000 ║
║ Total                               0.000 ║
╚═══════════════════════════════════════════╝

╔═╡ Size (-%) ╞═════╡ EVMInterpreter M3B3 ╞═╗
║ Mean                                0.000 ║
║ Best                                0.000 ║
║ Worst                               0.000 ║
║ Total                                 NaN ║
╠═╡ Cycles (-%) ╞═══╡ EVMInterpreter M3B3 ╞═╣
║ Mean                                0.000 ║
║ Best                                0.000 ║
║ Worst                               0.000 ║
║ Total                               0.000 ║
╠═╡ Ergs (-%) ╞═════╡ EVMInterpreter M3B3 ╞═╣
║ Mean                                0.000 ║
║ Best                                0.000 ║
║ Worst                               0.000 ║
║ Total                               0.000 ║
╠═╡ Ergs/gas ╞══════╡ EVMInterpreter M3B3 ╞═╣
║ ADD                                69.333 ║
║ MUL                                40.400 ║
║ SUB                                69.333 ║
║ DIV                                48.800 ║
║ SDIV                               65.600 ║
║ MOD                                47.600 ║
║ SMOD                               63.200 ║
║ ADDMOD                             39.625 ║
║ MULMOD                             36.625 ║
║ EXP                                 9.367 ║
║ SIGNEXTEND                         46.400 ║
║ LT                                 73.333 ║
║ GT                                 73.333 ║
║ SLT                                97.333 ║
║ SGT                                95.333 ║
║ EQ                                 73.333 ║
║ ISZERO                             65.000 ║
║ AND                                67.333 ║
║ OR                                 69.333 ║
║ XOR                                69.333 ║
║ NOT                                61.000 ║
║ BYTE                               77.333 ║
║ SHL                                75.333 ║
║ SHR                                73.333 ║
║ SAR                                91.333 ║
║ SGT                                95.333 ║
║ SHA3                               28.519 ║
║ ADDRESS                            93.781 ║
║ BALANCE                            73.230 ║
║ ORIGIN                           1389.969 ║
║ CALLER                             93.781 ║
║ CALLVALUE                          93.781 ║
║ CALLDATALOAD                       63.333 ║
║ CALLDATASIZE                       94.000 ║
║ CALLDATACOPY                       71.533 ║
║ CODESIZE                           91.000 ║
║ CODECOPY                          145.574 ║
║ GASPRICE                         1392.688 ║
║ EXTCODESIZE                         5.149 ║
║ EXTCODECOPY                         4.667 ║
║ RETURNDATASIZE                     89.000 ║
║ RETURNDATACOPY                     55.889 ║
║ EXTCODEHASH                         2.687 ║
║ BLOCKHASH                         244.700 ║
║ COINBASE                         1392.969 ║
║ TIMESTAMP                        1389.969 ║
║ NUMBER                           1389.969 ║
║ PREVRANDAO                       1389.969 ║
║ GASLIMIT                         1395.969 ║
║ CHAINID                          1389.969 ║
║ SELFBALANCE                       641.312 ║
║ BASEFEE                          1386.969 ║
║ POP                                81.500 ║
║ MLOAD                              80.186 ║
║ MSTORE                             82.069 ║
║ MSTORE8                            89.912 ║
║ SLOAD                              39.327 ║
║ SSTORE                              9.099 ║
║ JUMP                               37.333 ║
║ JUMPI                              32.818 ║
║ PC                                 94.281 ║
║ MSIZE                             103.781 ║
║ GAS                                88.281 ║
║ JUMPDEST                          127.562 ║
║ PUSH0                              91.281 ║
║ PUSH1                              78.854 ║
║ PUSH2                              96.854 ║
║ PUSH4                             158.854 ║
║ PUSH5                             180.854 ║
║ PUSH6                             202.854 ║
║ PUSH7                             224.854 ║
║ PUSH8                             246.854 ║
║ PUSH9                             268.854 ║
║ PUSH10                            290.854 ║
║ PUSH11                            310.854 ║
║ PUSH12                            334.854 ║
║ PUSH13                            356.854 ║
║ PUSH14                            378.854 ║
║ PUSH15                            400.854 ║
║ PUSH16                            422.854 ║
║ PUSH17                            444.854 ║
║ PUSH18                            466.854 ║
║ PUSH19                            488.854 ║
║ PUSH20                            510.854 ║
║ PUSH21                            532.854 ║
║ PUSH22                            554.854 ║
║ PUSH23                            576.854 ║
║ PUSH24                            598.854 ║
║ PUSH25                            620.854 ║
║ PUSH26                            642.854 ║
║ PUSH27                            664.854 ║
║ PUSH28                            686.854 ║
║ PUSH29                            708.854 ║
║ PUSH30                            730.854 ║
║ PUSH31                            752.854 ║
║ PUSH32                            774.854 ║
║ DUP1                               63.000 ║
║ DUP2                               67.000 ║
║ DUP3                               67.000 ║
║ DUP4                               67.000 ║
║ DUP5                               67.000 ║
║ DUP6                               67.000 ║
║ DUP7                               67.000 ║
║ DUP8                               67.000 ║
║ DUP9                               67.000 ║
║ DUP10                              67.000 ║
║ DUP11                              67.000 ║
║ DUP12                              67.000 ║
║ DUP13                              65.000 ║
║ DUP14                              67.000 ║
║ DUP15                              67.000 ║
║ DUP16                              67.000 ║
║ SWAP1                              67.667 ║
║ SWAP2                              67.667 ║
║ SWAP3                              67.667 ║
║ SWAP4                              67.667 ║
║ SWAP5                              67.667 ║
║ SWAP6                              67.667 ║
║ SWAP7                              67.667 ║
║ SWAP8                              67.667 ║
║ SWAP9                              67.667 ║
║ SWAP10                             67.667 ║
║ SWAP11                             65.667 ║
║ SWAP12                             67.667 ║
║ SWAP13                             67.667 ║
║ SWAP14                             67.667 ║
║ SWAP15                             67.667 ║
║ SWAP16                             67.667 ║
║ CALL                               56.371 ║
║ STATICCALL                         53.248 ║
║ DELEGATECALL                       52.286 ║
║ CREATE                              5.046 ║
║ CREATE2                             7.066 ║
║ RETURN                              1.000 ║
║ REVERT                              1.000 ║
╠═╡ Ergs/gas (-%) ╞═╡ EVMInterpreter M3B3 ╞═╣
╚═══════════════════════════════════════════╝

╔═╡ Size (-%) ╞═════╡ EVMInterpreter MzB3 ╞═╗
║ Mean                                0.000 ║
║ Best                                0.000 ║
║ Worst                               0.000 ║
║ Total                                 NaN ║
╠═╡ Cycles (-%) ╞═══╡ EVMInterpreter MzB3 ╞═╣
║ Mean                                0.000 ║
║ Best                                0.000 ║
║ Worst                               0.000 ║
║ Total                               0.000 ║
╠═╡ Ergs (-%) ╞═════╡ EVMInterpreter MzB3 ╞═╣
║ Mean                                0.000 ║
║ Best                                0.000 ║
║ Worst                               0.000 ║
║ Total                               0.000 ║
╚═══════════════════════════════════════════╝

╔═╡ Size (-%) ╞══════════╡ Real life M3B3 ╞═╗
║ Mean                                0.000 ║
║ Best                                0.000 ║
║ Worst                               0.000 ║
║ Total                               0.000 ║
╠═╡ Cycles (-%) ╞════════╡ Real life M3B3 ╞═╣
║ Mean                                0.000 ║
║ Best                                0.000 ║
║ Worst                               0.000 ║
║ Total                               0.000 ║
╠═╡ Ergs (-%) ╞══════════╡ Real life M3B3 ╞═╣
║ Mean                                0.000 ║
║ Best                                0.000 ║
║ Worst                               0.000 ║
║ Total                               0.000 ║
╚═══════════════════════════════════════════╝

╔═╡ Size (-%) ╞══════════╡ Real life MzB3 ╞═╗
║ Mean                                0.000 ║
║ Best                                0.000 ║
║ Worst                               0.000 ║
║ Total                               0.000 ║
╠═╡ Cycles (-%) ╞════════╡ Real life MzB3 ╞═╣
║ Mean                                0.000 ║
║ Best                                0.000 ║
║ Worst                               0.000 ║
║ Total                               0.000 ║
╠═╡ Ergs (-%) ╞══════════╡ Real life MzB3 ╞═╣
║ Mean                                0.000 ║
║ Best                                0.000 ║
║ Worst                               0.000 ║
║ Total                               0.000 ║
╚═══════════════════════════════════════════╝

liblangutil/Token.h

libyul/CMakeLists.txt

hedgar2017

Ready after the changelog tweak!

antonbaliasnikov · 2024-05-22T15:13:42Z

Ready after the changelog tweak!

This is done.

hedgar2017

Hey @abinavpp, we've moved the changelog update to this branch in order to minimize your patch.

@antonbaliasnikov please be careful with the global substitution of versions!

.github/workflows/build-release.yaml

.github/actions/build/action.yml

antonbaliasnikov force-pushed the aba-ci-update branch 7 times, most recently from 0d133fc to bc16657 Compare May 20, 2024 14:06

antonbaliasnikov commented May 22, 2024

View reviewed changes

liblangutil/Token.h Outdated Show resolved Hide resolved

antonbaliasnikov commented May 22, 2024

View reviewed changes

libyul/CMakeLists.txt Show resolved Hide resolved

antonbaliasnikov force-pushed the aba-ci-update branch from 509cbfc to 0a7e217 Compare May 22, 2024 14:59

antonbaliasnikov changed the title ~~[WIP] [DO NOT MERGE] ci: test new ci~~ ci: optimize and unify scripts and build process May 22, 2024

antonbaliasnikov marked this pull request as ready for review May 22, 2024 15:03

antonbaliasnikov requested review from abinavpp and hedgar2017 May 22, 2024 15:04

hedgar2017 requested changes May 22, 2024

View reviewed changes

antonbaliasnikov force-pushed the aba-ci-update branch from 0a7e217 to 895e054 Compare May 22, 2024 15:13

hedgar2017 previously approved these changes May 22, 2024

View reviewed changes

antonbaliasnikov dismissed hedgar2017’s stale review via 18602ba May 22, 2024 16:30

antonbaliasnikov requested a review from hedgar2017 May 22, 2024 18:44

hedgar2017 approved these changes May 22, 2024

View reviewed changes

abinavpp reviewed May 22, 2024

View reviewed changes

.github/workflows/build-release.yaml Outdated Show resolved Hide resolved

.github/workflows/build-release.yaml Outdated Show resolved Hide resolved

.github/actions/build/action.yml Outdated Show resolved Hide resolved

hedgar2017 self-requested a review May 23, 2024 07:44

antonbaliasnikov force-pushed the aba-ci-update branch from 18602ba to 83e0ecb Compare May 23, 2024 08:22

hedgar2017 previously approved these changes May 23, 2024

View reviewed changes

antonbaliasnikov changed the title ~~ci: optimize and unify scripts and build process~~ [DO NOT MERGE] ci: optimize and unify scripts and build process May 23, 2024

antonbaliasnikov dismissed hedgar2017’s stale review via 16e92a7 May 24, 2024 10:42

antonbaliasnikov force-pushed the aba-ci-update branch from 83e0ecb to 16e92a7 Compare May 24, 2024 10:42

docs: correct changelog for version 0.8.25

2ba96f4

antonbaliasnikov added 2 commits May 24, 2024 11:50

chore: rebranding to ZKsync from ZKEVM

1d6e3c5

ci: optimize and unify scripts and build process

1cba9b0

antonbaliasnikov force-pushed the aba-ci-update branch from 16e92a7 to 1cba9b0 Compare May 24, 2024 10:50

antonbaliasnikov closed this May 28, 2024

antonbaliasnikov deleted the aba-ci-update branch May 28, 2024 12:06

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

[DO NOT MERGE] ci: optimize and unify scripts and build process #550

[DO NOT MERGE] ci: optimize and unify scripts and build process #550

antonbaliasnikov commented May 20, 2024 •

edited

Loading

github-actions bot commented May 21, 2024 •

edited

Loading

hedgar2017 left a comment

antonbaliasnikov commented May 22, 2024

hedgar2017 left a comment

[DO NOT MERGE] ci: optimize and unify scripts and build process #550

[DO NOT MERGE] ci: optimize and unify scripts and build process #550

Conversation

antonbaliasnikov commented May 20, 2024 • edited Loading

What ❔

Why ❔

Checklist

github-actions bot commented May 21, 2024 • edited Loading

hedgar2017 left a comment

Choose a reason for hiding this comment

antonbaliasnikov commented May 22, 2024

hedgar2017 left a comment

Choose a reason for hiding this comment

antonbaliasnikov commented May 20, 2024 •

edited

Loading

github-actions bot commented May 21, 2024 •

edited

Loading