Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

ci: shared jobs with msys2 windows build #726

Merged
merged 3 commits into from
Oct 22, 2024
Merged

ci: shared jobs with msys2 windows build #726

merged 3 commits into from
Oct 22, 2024

Conversation

antonbaliasnikov
Copy link
Collaborator

No description provided.

@github-actions GitHub Actions
Copy link 

╔═╡ Size (-%) ╞════════════════╡ All M3B3 ╞═╗
║ Best                                0.000 ║
║ Worst                               0.000 ║
║ Total                               0.000 ║
╠═╡ Cycles (-%) ╞══════════════╡ All M3B3 ╞═╣
║ Best                                0.487 ║
║ Worst                             -26.594 ║
║ Total                              -0.081 ║
╠═╡ Ergs (-%) ╞════════════════╡ All M3B3 ╞═╣
║ Best                                0.020 ║
║ Worst                              -8.068 ║
║ Total                              -0.000 ║
╚═══════════════════════════════════════════╝

╔═╡ Size (-%) ╞════════════════╡ All MzB3 ╞═╗
║ Best                                0.000 ║
║ Worst                               0.000 ║
║ Total                               0.000 ║
╠═╡ Cycles (-%) ╞══════════════╡ All MzB3 ╞═╣
║ Best                                0.482 ║
║ Worst                             -26.594 ║
║ Total                              -0.074 ║
╠═╡ Ergs (-%) ╞════════════════╡ All MzB3 ╞═╣
║ Best                                0.020 ║
║ Worst                              -8.068 ║
║ Total                              -0.000 ║
╚═══════════════════════════════════════════╝

╔═╡ Size (-%) ╞═════╡ EVMInterpreter M3B3 ╞═╗
║ Best                                0.000 ║
║ Worst                               0.000 ║
║ Total                                 NaN ║
╠═╡ Cycles (-%) ╞═══╡ EVMInterpreter M3B3 ╞═╣
║ Best                                0.000 ║
║ Worst                             -26.594 ║
║ Total                              -5.393 ║
╠═╡ Ergs (-%) ╞═════╡ EVMInterpreter M3B3 ╞═╣
║ Best                                0.000 ║
║ Worst                              -8.068 ║
║ Total                              -1.799 ║
╠═╡ Ergs/gas ╞══════╡ EVMInterpreter M3B3 ╞═╣
║ ADD                                38.750 ║
║ MUL                                23.250 ║
║ SUB                                38.750 ║
║ DIV                                25.650 ║
║ SDIV                               41.250 ║
║ MOD                                25.650 ║
║ SMOD                               38.850 ║
║ ADDMOD                             20.656 ║
║ MULMOD                             23.656 ║
║ EXP                                 7.138 ║
║ SIGNEXTEND                         24.450 ║
║ LT                                 42.750 ║
║ GT                                 42.750 ║
║ SLT                                64.750 ║
║ SGT                                64.750 ║
║ EQ                                 42.750 ║
║ ISZERO                             36.417 ║
║ AND                                38.750 ║
║ OR                                 38.750 ║
║ XOR                                38.750 ║
║ NOT                                32.417 ║
║ BYTE                               46.750 ║
║ SHL                                42.750 ║
║ SHR                                42.750 ║
║ SAR                                60.750 ║
║ SGT                                64.750 ║
║ SHA3                               26.326 ║
║ ADDRESS                            47.812 ║
║ BALANCE                            39.059 ║
║ ORIGIN                           1351.625 ║
║ CALLER                             47.812 ║
║ CALLVALUE                          47.812 ║
║ CALLDATALOAD                       34.750 ║
║ CALLDATASIZE                       48.125 ║
║ CALLDATACOPY                       49.492 ║
║ CODESIZE                           48.625 ║
║ CODECOPY                           60.487 ║
║ GASPRICE                         1348.438 ║
║ EXTCODESIZE                         3.702 ║
║ EXTCODECOPY                         3.769 ║
║ RETURNDATASIZE                     46.500 ║
║ RETURNDATACOPY                     43.222 ║
║ EXTCODEHASH                         4.884 ║
║ BLOCKHASH                         240.119 ║
║ COINBASE                         1348.625 ║
║ TIMESTAMP                        1342.625 ║
║ NUMBER                           1342.625 ║
║ PREVRANDAO                       1342.625 ║
║ GASLIMIT                         1348.625 ║
║ CHAINID                          1336.625 ║
║ SELFBALANCE                       639.250 ║
║ BASEFEE                          1342.625 ║
║ POP                                38.625 ║
║ MLOAD                              51.590 ║
║ MSTORE                             55.248 ║
║ MSTORE8                            64.716 ║
║ SLOAD                              20.632 ║
║ SSTORE                              4.644 ║
║ JUMP                               17.000 ║
║ JUMPI                              16.727 ║
║ PC                                 48.312 ║
║ MSIZE                              54.812 ║
║ GAS                                45.312 ║
║ JUMPDEST                           65.625 ║
║ PUSH0                              45.312 ║
║ PUSH1                              41.958 ║
║ PUSH2                              47.375 ║
║ PUSH4                              50.208 ║
║ PUSH5                              51.625 ║
║ PUSH6                              53.042 ║
║ PUSH7                              54.458 ║
║ PUSH8                              55.875 ║
║ PUSH9                              57.292 ║
║ PUSH10                             58.708 ║
║ PUSH11                             60.125 ║
║ PUSH12                             61.542 ║
║ PUSH13                             62.958 ║
║ PUSH14                             64.375 ║
║ PUSH15                             65.792 ║
║ PUSH16                             67.208 ║
║ PUSH17                             68.625 ║
║ PUSH18                             70.042 ║
║ PUSH19                             71.458 ║
║ PUSH20                             72.875 ║
║ PUSH21                             74.292 ║
║ PUSH22                             75.708 ║
║ PUSH23                             77.125 ║
║ PUSH24                             78.542 ║
║ PUSH25                             79.958 ║
║ PUSH26                             81.375 ║
║ PUSH27                             82.792 ║
║ PUSH28                             84.208 ║
║ PUSH29                             85.625 ║
║ PUSH30                             87.042 ║
║ PUSH31                             88.458 ║
║ PUSH32                             87.875 ║
║ DUP1                               34.417 ║
║ DUP2                               36.417 ║
║ DUP3                               36.417 ║
║ DUP4                               36.417 ║
║ DUP5                               36.417 ║
║ DUP6                               36.417 ║
║ DUP7                               36.417 ║
║ DUP8                               36.417 ║
║ DUP9                               36.417 ║
║ DUP10                              36.417 ║
║ DUP11                              36.417 ║
║ DUP12                              36.417 ║
║ DUP13                              36.417 ║
║ DUP14                              36.417 ║
║ DUP15                              36.417 ║
║ DUP16                              36.417 ║
║ SWAP1                              41.083 ║
║ SWAP2                              41.083 ║
║ SWAP3                              41.083 ║
║ SWAP4                              41.083 ║
║ SWAP5                              41.083 ║
║ SWAP6                              41.083 ║
║ SWAP7                              41.083 ║
║ SWAP8                              41.083 ║
║ SWAP9                              41.083 ║
║ SWAP10                             41.083 ║
║ SWAP11                             41.083 ║
║ SWAP12                             41.083 ║
║ SWAP13                             41.083 ║
║ SWAP14                             41.083 ║
║ SWAP15                             41.083 ║
║ SWAP16                             41.083 ║
║ CALL                               36.115 ║
║ STATICCALL                         35.161 ║
║ DELEGATECALL                       34.205 ║
║ CREATE                              4.075 ║
║ CREATE2                             5.547 ║
║ RETURN                              1.000 ║
║ REVERT                              1.000 ║
╠═╡ Ergs/gas (-%) ╞═╡ EVMInterpreter M3B3 ╞═╣
║ BALANCE                           -85.379 ║
║ EXTCODESIZE                        -1.583 ║
║ EXTCODECOPY                        -1.489 ║
║ EXTCODEHASH                        -4.786 ║
║ SLOAD                              -7.442 ║
║ SSTORE                             -4.301 ║
║ CALL                               -1.352 ║
║ STATICCALL                         -1.394 ║
║ DELEGATECALL                       -1.338 ║
║ CREATE                             -9.453 ║
║ CREATE2                           -10.439 ║
╚═══════════════════════════════════════════╝

╔═╡ Size (-%) ╞═════╡ EVMInterpreter MzB3 ╞═╗
║ Best                                0.000 ║
║ Worst                               0.000 ║
║ Total                                 NaN ║
╠═╡ Cycles (-%) ╞═══╡ EVMInterpreter MzB3 ╞═╣
║ Best                                0.000 ║
║ Worst                             -26.594 ║
║ Total                              -5.393 ║
╠═╡ Ergs (-%) ╞═════╡ EVMInterpreter MzB3 ╞═╣
║ Best                                0.000 ║
║ Worst                              -8.068 ║
║ Total                              -1.799 ║
╚═══════════════════════════════════════════╝

╔═╡ Size (-%) ╞══════════╡ Real life M3B3 ╞═╗
║ Best                                0.000 ║
║ Worst                               0.000 ║
║ Total                               0.000 ║
╠═╡ Cycles (-%) ╞════════╡ Real life M3B3 ╞═╣
║ Best                                0.000 ║
║ Worst                              -0.075 ║
║ Total                              -0.043 ║
╠═╡ Ergs (-%) ╞══════════╡ Real life M3B3 ╞═╣
║ Best                                0.016 ║
║ Worst                              -0.183 ║
║ Total                              -0.002 ║
╚═══════════════════════════════════════════╝

╔═╡ Size (-%) ╞══════════╡ Real life MzB3 ╞═╗
║ Best                                0.000 ║
║ Worst                               0.000 ║
║ Total                               0.000 ║
╠═╡ Cycles (-%) ╞════════╡ Real life MzB3 ╞═╣
║ Best                                0.000 ║
║ Worst                              -0.075 ║
║ Total                              -0.040 ║
╠═╡ Ergs (-%) ╞══════════╡ Real life MzB3 ╞═╣
║ Best                                0.016 ║
║ Worst                              -0.185 ║
║ Total                              -0.002 ║
╚═══════════════════════════════════════════╝

@antonbaliasnikov antonbaliasnikov marked this pull request as ready for review October 21, 2024 16:35
@antonbaliasnikov antonbaliasnikov changed the title ci: shared jobs with msys2 windows build [0.8.28] ci: shared jobs with msys2 windows build Oct 21, 2024
@antonbaliasnikov
Copy link
Collaborator Author

@hedgar2017 , @abinavpp , do you know what can cause the benchmark regressions? Is this expected?

hedgar2017
hedgar2017 requested changes Oct 22, 2024
View reviewed changes
Copy link
Collaborator

@hedgar2017 hedgar2017 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hey @antonbaliasnikov, it looks like there are different commits of compiler-tester used in reference and candidate: https://github.com/matter-labs/era-solidity/actions/runs/11442884776/job/31835185943#step:4:1
Do you know why it might be happening?

@antonbaliasnikov
Copy link
Collaborator Author

Hey @antonbaliasnikov, it looks like there are different commits of compiler-tester used in reference and candidate: https://github.com/matter-labs/era-solidity/actions/runs/11442884776/job/31835185943#step:4:1 Do you know why it might be happening?

@hedgar2017 , ah, I see that https://github.com/matter-labs/era-compiler-tester/releases/tag/era-solidity-test tag was created 2 weeks ago. Should we remove it?

@antonbaliasnikov antonbaliasnikov enabled auto-merge (squash) October 22, 2024 08:03
@hedgar2017
Copy link
Collaborator

Hey @antonbaliasnikov, it looks like there are different commits of compiler-tester used in reference and candidate: https://github.com/matter-labs/era-solidity/actions/runs/11442884776/job/31835185943#step:4:1 Do you know why it might be happening?

@hedgar2017 , ah, I see that https://github.com/matter-labs/era-compiler-tester/releases/tag/era-solidity-test tag was created 2 weeks ago. Should we remove it?

Sure.
The tag is only used for candidate, isn't it?

@antonbaliasnikov antonbaliasnikov merged commit 0b99eea into 0.8.28 Oct 22, 2024
14 checks passed
@antonbaliasnikov antonbaliasnikov deleted the aba-0.8.28-ci branch October 22, 2024 08:28
@antonbaliasnikov
Copy link
Collaborator Author

Hey @antonbaliasnikov, it looks like there are different commits of compiler-tester used in reference and candidate: https://github.com/matter-labs/era-solidity/actions/runs/11442884776/job/31835185943#step:4:1 Do you know why it might be happening?

@hedgar2017 , ah, I see that https://github.com/matter-labs/era-compiler-tester/releases/tag/era-solidity-test tag was created 2 weeks ago. Should we remove it?

Sure. The tag is only used for candidate, isn't it?

Right, and this caused the difference between main and this tag.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@hedgar2017 hedgar2017 hedgar2017 approved these changes

@abinavpp abinavpp Awaiting requested review from abinavpp

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@antonbaliasnikov @hedgar2017