-
Notifications
You must be signed in to change notification settings - Fork 144
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. Weβll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: Correct FOUNDRY_BIN_URL
and FOUNDRY_BIN_PATH
#914
base: main
Are you sure you want to change the base?
Conversation
FOUNDRY_BIN_URL
and FOUNDRY_BIN_PATH
FOUNDRY_BIN_URL
and FOUNDRY_BIN_PATH
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for spotting this! :)
No problem :D Hope you guys produce a new version with better performance, testing is extremely slow rn. |
What kind of tests are you running exactly? We are aware of the general performance issue with EraVM, but unless you are running fuzz tests (or invariant tests) those shouldn't take significantly longer, please open an issue. |
Those tests are fuzz tests, but there are only 26 of them with runs = 16 in |
I see, yeah unfortunately not a lot we can do there other than recommending using a different profile with less fuzz runs for development and keep a higher number of fuzz runs in CI for added security. |
What π»
FOUNDRY_BIN_URL
andFOUNDRY_BIN_PATH
.Why β
update()
function in the script install originalfoundryup
instead of updatefoundryup-zksync
.Evidence π·
Documentation π
Please ensure the following before submitting your PR: