Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Request]: update mock responses to match return formats #84

Open
cpb8010 opened this issue Mar 6, 2025 · 0 comments
Open

[Request]: update mock responses to match return formats #84

cpb8010 opened this issue Mar 6, 2025 · 0 comments
Labels
enhancement New feature or request

Comments

@cpb8010
Copy link
Contributor

cpb8010 commented Mar 6, 2025

📝 Description

There are some hard-coded mocks in the SDK tests that no longer reflect the ABI and data formats returned by the contracts.

We either need to manually update these or figure out how to avoid these kinds of manually (AI) generated mocks.

🤔 Rationale

For now I've updated the production code to expect what local node returns instead of what a test net might return, which fixes the test that no longer has good data.

Ideally these mocks are both correct and useful to ensure we will have good test net performance, but they are misleading now!

📋 Additional context

@jackpooleyml Can explain the purpose of these tests, and if they will also impact the rust tests!
@cpb8010 cpb8010 added the enhancement New feature or request label Mar 6, 2025
cpb8010 added a commit that referenced this issue Mar 6, 2025
@cpb8010
fix: update test mock
6c5959b 
The log parsing format is broken because the return type changed,
but regenerating the log format is non-trival so that can be updated later.

introducing #84
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
enhancement New feature or request
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@cpb8010