[Draft] feat: add guardian recovery #52
Draft
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
feat: add initial guardian recovery views
feat: add confirm guardian view
fix: small UI and organization improvements
chore: update upstream
Feat/add recover account views
Feat/add contracts integration
Co-authored-by: Lukasz Romanowski <[email protected]>
When deploying the contracts, it should create the file, blocking the build
Can have a different test to make sure this gets updated or put the contract build step into the other builds
Try encoding the local contracts directly instead of via env vars doesn't appear to work locally...
This was correct on creation, but wrong on signing
This was super tough to find and would have been a compile error had we imported the abi directly from the contracts! This is something I'm going to look into so we don't lose our minds
You just have to know that the quest address is added via .env.local so the object in the config isn't used
* feat: execute pending recovery on login * feat: move recovery client to sdk * feat: add account-not-ready view * chore: fix pnpm lock --------- Co-authored-by: aon <[email protected]>
Having to manually update the ABI kinda defeats the point of type safety, but it's clear the auto-generated one doesn't play nice with the existing file so more work will be necessary to update it so it's compatible
Picks up a fix from the publish function for the correct abi
It looks like nuxt builds don't like the poorly formatted json, so instead of trying to pretty print the abi automatically we'll rely on the editor tools to do this. At the very least the publish step is documented?
problem was not the file format, but the file name change
CI is behaving strange?
This explains why the build was failing
This should be fine because we aren't actually using it
* feat: add placeholder to account select component * feat: add init recovery method to be used by any client * feat: improve recovery flow * feat: improve confirm recovery flow * feat: improve styles
* feat: update to work with new guardian validator * chore: update contracts submodule * chore: remove duplicated hooks * chore: update guardian validator abi * feat: update to match new contracts
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Add guardian recovery functionality.
Additional context
We'll be working on
guardian-recoverybranch. We'll ask for PR reviews when the feature is complete.This PR must be merged together with matter-labs/zksync-sso-clave-contracts#261