-
-
Notifications
You must be signed in to change notification settings - Fork 530
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
New vehicle action #1628
New vehicle action #1628
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
What are those cmake.yml for? 🤔
@rligocki should we try another effort to get this in? |
Let's do it. But I will need little bit of guidance. |
@rligocki I've squashed all your commits into one, and removed the files you had added by accident. We now need to add the actual implementation back in. I suggest you fetch this state and add a commit on top with the implementation. The way to get to this state (without ugly merges) would be: The steps below assume that
This should wipe your changes and reset to the state of this PR. Note that it does not have any of the actual implementation here. So if you have that one somewhere locally, make sure to stash it or put it into a branch to use it later. |
Now it should contain implementation and tests. This should work without any problem for 1.12 and 1.11 version of PX4. Only update of proto needs to be done. |
@rligocki this is still conflicting, see what GitHub says: ⬇️. |
CI did not passed. Is it possible that it is caused by merge requests, that has been done? |
Based on latest CI from main branch, it looks like PX4 1.12 tests failed because of latest commits in main branch. |
Now it should be ok. |
@rligocki CI seems to fail the new test, any idea?
https://github.com/mavlink/MAVSDK/runs/5014636341?check_suite_focus=true#step:4:47103 |
Looks good. I'll merge it next time I go through all PRs. |
50df0ba
to
90bf3f8
Compare
Rebased and force pushed. |
Thanks @rligocki and sorry it took a while. |
No description provided.