More command result options #1793
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
JonasVautherin
previously approved these changes
May 29, 2022
julianoes
force-pushed
the
pr-command-improvements
branch
from
7c868de to
1924239
Compare
In order to prevent too many commands from clogging the queue, we remove them if they look identical. This changes it so that we only drop a command if it does not come with a callback. If it has a callback associated with it, it's better to call it anyway, otherwise odd races or just Denied results when you don't expect it tend to be the result.
This adds TemporarilyRejected, Failed, and Cancelled to the possible command sender results.
The command sender now exposes TemporarilyRejected, Failed, and Cancelled. Also, the result CommandDenied was renamed to Denied which actually made the refactoring a little easier as it made the compiler surface all places where CommandDenied was used, and so where it needed to be extended with TemporarilyRejected.
julianoes
force-pushed
the
pr-command-improvements
branch
from
1924239 to
6827a29
Compare
JonasVautherin
approved these changes
May 30, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Requires mavlink/MAVSDK-Proto#289.